Move includes in crypto_onetimeauth_poly1305.h outside of extern C #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes being outside of `extern "C"` are de-facto standard in all other include files of libsodium. At the same time, having inside the `extern "C"` is causing problem with C++ vs. C toolchain being confused about which libraries should be linked. This was especially painful while working on `swift-sodium` integration with windows.
|
Thank you! |
jedisct1
pushed a commit
that referenced
this pull request
Jan 17, 2024
…1345) Includes being outside of `extern "C"` are de-facto standard in all other include files of libsodium. At the same time, having inside the `extern "C"` is causing problem with C++ vs. C toolchain being confused about which libraries should be linked. This was especially painful while working on `swift-sodium` integration with windows.
ghazel
pushed a commit
to clostra/libsodium
that referenced
this pull request
Feb 23, 2024
…edisct1#1345) Includes being outside of `extern "C"` are de-facto standard in all other include files of libsodium. At the same time, having inside the `extern "C"` is causing problem with C++ vs. C toolchain being confused about which libraries should be linked. This was especially painful while working on `swift-sodium` integration with windows.
Repository owner
locked and limited conversation to collaborators
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes being outside of
extern "C"are de-facto standard in all other include files of libsodium.At the same time, having inside the
extern "C"is causing problem with C++ vs. C toolchain being confused about which libraries should be linked. This was especially painful while working onswift-sodiumintegration with windows.