Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eqlogic delete confirmation #3019

Open
wants to merge 4 commits into
base: alpha
Choose a base branch
from

Conversation

Mips2648
Copy link
Collaborator

@Mips2648 Mips2648 commented Jan 27, 2025

Description

Today, when we delete an eqLogic we see a confirmation prompt displaying too much data.
To my understanding, this prompt is supposed to warn user in case the eqLogic is (actually) used somewhere in Jeedom to prevent futur orphans.
The issues are:

  • we see command from the eqLogic itself (in case an action command is linked to an info command of the same eqLogic)
  • we see the current object owning the eqLogic
  • we see commands that current eqLogic is using (mostly the case for virtual but could be the case for others as well)

example with a virtual in which I copied a eqLogic from sonos:
image

while I expect to not see any warning if I delete it (because the deletion will not bring any issue); example after this PR:
image

Of course, if I try to delete the "source" eqLogic (from sonos plugin in my example), I still see the full list of commands (the one from virtual eqLogic:
image

Suggested changelog entry

Amélioration du message de confirmation d'un eqLogic

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

@NebzHB
Copy link
Contributor

NebzHB commented Jan 27, 2025

good catch ! might be interesting to publish on stable too ! (no break)

@Mips2648 Mips2648 requested a review from zoic21 January 27, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants