Fix eqlogic delete confirmation #3019
Open
+22
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, when we delete an eqLogic we see a confirmation prompt displaying too much data.
To my understanding, this prompt is supposed to warn user in case the eqLogic is (actually) used somewhere in Jeedom to prevent futur orphans.
The issues are:
example with a virtual in which I copied a eqLogic from sonos:
while I expect to not see any warning if I delete it (because the deletion will not bring any issue); example after this PR:
Of course, if I try to delete the "source" eqLogic (from sonos plugin in my example), I still see the full list of commands (the one from virtual eqLogic:
Suggested changelog entry
Amélioration du message de confirmation d'un eqLogic
Related issues/external references
Fixes #
Types of changes
PR checklist