Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 50xx NVIDIA Links to global stores #3210

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add 50xx NVIDIA Links to global stores #3210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2d809c
Update nvidia-gb.ts
Mr-Tech-13 Jan 31, 2025
03564dd
Update nvidia GB and DE
Mr-Tech-13 Jan 31, 2025
f5441c8
Merge branch 'jef:main' into main
Mr-Tech-13 Jan 31, 2025
ea78b94
Update nvidia-fr.ts
Mr-Tech-13 Jan 31, 2025
4cc6741
Update nvidia-fr.ts
Mr-Tech-13 Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/store/model/nvidia-de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
currency: '€',
labels: {
inStock: {
container: '.buy',
container: 'span.buy-link-atc',
text: ['In den Einkaufswagen', 'JETZT KAUFEN'],
},
outOfStock: {
container: '.buy',
container: 'span.buy-link-atc',
text: ['DERZEIT NICHT VERFÜGBAR'],
},
},

Check failure on line 13 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Delete `····`

Check failure on line 13 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Trailing spaces not allowed
},
links: [
{
Expand Down Expand Up @@ -55,7 +55,27 @@
series: '3090',
url: 'https://shop.nvidia.com/de-de/geforce/store/gpu/?page=1&limit=9&locale=de-de&category=GPU&gpu=RTX%203090&manufacturer=NVIDIA',
},
{
brand: 'nvidia',
model: 'founders edition',
series: '5080',
url: 'https://marketplace.nvidia.com/de-de/consumer/graphics-cards/?locale=de-de&page=1&limit=12&gpu=RTX%205080&manufacturer=NVIDIA',

Check failure on line 62 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Delete `····`

Check failure on line 62 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Trailing spaces not allowed
},
{
brand: 'nvidia',
model: 'founders edition',
series: '5090',
url: 'https://marketplace.nvidia.com/de-de/consumer/graphics-cards/?locale=de-de&page=1&limit=12&gpu=RTX%205090&manufacturer=NVIDIA',

Check failure on line 68 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Delete `····`

Check failure on line 68 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Trailing spaces not allowed
},
],
name: 'nvidia-de',
country: 'DE',
};
/* Copy Paste Template
{
brand: 'nvidia',
model: 'founders edition',
series: '',
url: '',

Check failure on line 79 in src/store/model/nvidia-de.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Trailing spaces not allowed
},
*/
26 changes: 23 additions & 3 deletions src/store/model/nvidia-fr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
currency: '€',
labels: {
inStock: {
container: '.buy',
text: ['ajouter au panier', 'acheter maintenant'],
container: 'span.buy-link-atc',
text: ['Acheter maintenant'],
},
outOfStock: {
container: '.buy',
container: 'span.buy-link-atc',
text: ['RUPTURE DE STOCK'],
},
},
Expand Down Expand Up @@ -55,7 +55,27 @@
series: '3090',
url: 'https://shop.nvidia.com/fr-fr/geforce/store/gpu/?page=1&limit=9&locale=fr-fr&category=GPU&gpu=RTX%203090&manufacturer=NVIDIA',
},
{
brand: 'nvidia',
model: 'founders edition',
series: '5090',
url: 'https://marketplace.nvidia.com/fr-fr/consumer/graphics-cards/?locale=fr-fr&page=1&limit=12&gpu=RTX%205090&manufacturer=NVIDIA',

Check failure on line 62 in src/store/model/nvidia-fr.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Delete `····`

Check failure on line 62 in src/store/model/nvidia-fr.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Trailing spaces not allowed
},
{
brand: 'nvidia',
model: 'founders edition',
series: '5080',
url: 'https://marketplace.nvidia.com/fr-fr/consumer/graphics-cards/?locale=fr-fr&page=1&limit=12&gpu=RTX%205080&manufacturer=NVIDIA',

Check failure on line 68 in src/store/model/nvidia-fr.ts

View workflow job for this annotation

GitHub Actions / Build and lint 

Delete `····`
},
],
name: 'nvidia-fr',
country: 'FR',
};
/* Copy Paste Template
{
brand: 'nvidia',
model: 'founders edition',
series: '',
url: '',
},
*/
35 changes: 31 additions & 4 deletions src/store/model/nvidia-gb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ export const NvidiaGB: Store = {
currency: '£',
labels: {
inStock: {
container: '.buy',
text: ['add to cart', 'buy now'],
container: 'span.buy-link-atc',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the container ID for a founders being in stock is that same as it being in stock for a third party card? I'm raising this because the button looks different between founders and third party cards. When I checked the element for an out-of-stock FE card and an in stock third party card, they're different as well.

RTX 5080 FE in stock
image

Third party card in stock
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to fix it. I only designed it with fe cards in mind because as far as I could tell nvidia doesn't directly sell third party cards as far as I know. It's more efficient to track the third party

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the same, I only want an FE card. The container ID you have works for third party cards but isn't the same for out of stock founders card from what I can see. It's annoying because the the founders card isn't in stock, we can't check what the ID is for the button.

text: ['Buy Now', 'Add to Cart']
},
outOfStock: {
container: '.buy',
text: ['out of stock'],
container: 'span.buy-link-atc',
text: ['Out of Stock'],
},
},
links: [
Expand Down Expand Up @@ -55,7 +55,34 @@ export const NvidiaGB: Store = {
series: '3090',
url: 'https://shop.nvidia.com/en-gb/geforce/store/gpu/?page=1&limit=9&locale=en-gb&category=GPU&gpu=RTX%203090&manufacturer=NVIDIA',
},
{
brand: 'asus',
model: 'dual',
series: '4070',
url: 'https://marketplace.nvidia.com/en-gb/consumer/graphics-cards/?locale=en-gb&page=1&limit=12&manufacturer=ASUS&gpu=RTX%204070&',
},
{
brand: 'nvidia',
model: 'founders edition',
series: '5090',
url: 'https://marketplace.nvidia.com/en-gb/consumer/graphics-cards/?locale=en-gb&page=1&limit=12&gpu=RTX%205090&manufacturer=NVIDIA',
},
{
brand: 'nvidia',
model: 'founders edition',
series: '5080',
url: 'https://marketplace.nvidia.com/en-gb/consumer/graphics-cards/?locale=en-gb&page=1&limit=12&manufacturer=NVIDIA&gpu=RTX%205080&',
},
],
name: 'nvidia-gb',
country: 'UK',
};

/* Copy Paste Template
{
brand: 'nvidia',
model: 'founders edition',
series: '',
url: '',
},
*/
Loading