fix 11.75 conversions

jeffwhansen · Jan 20, 2024 · 86cd1a5 · 86cd1a5
1 parent 370fbd2
commit 86cd1a5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/Distance.php b/src/Distance.php
@@ -206,7 +206,7 @@ public function convertToEnglish($value, $cmValue = null)
         $feet = floor($length / 12);
         $inch = $length - 12 * $feet;
 
-        if ($inch > 11.75) {
+        if ($inch > 11.78) {
             $feet++;
             $inch = 0;
         }

diff --git a/tests/DistanceTest.php b/tests/DistanceTest.php
@@ -35,24 +35,29 @@
 
 it('can convert 18 from english to metric', function () {
     $result = Distance::fromFeet(18)->to(Format::METRIC);
-    expect($result)->toEqual(5.49);
+    expect($result)->toEqual(5.486);
 });
 
 it('can convert "18" from english to metric', function () {
     $result = Distance::fromFeet("18")->to(Format::METRIC);
-    expect($result)->toEqual(5.49);
+    expect($result)->toEqual(5.486);
 });
 
 it('can convert "18-2" from english to metric', function () {
     $result = Distance::fromFeet("18-2")->to(Format::METRIC);
-    expect($result)->toEqual(5.54);
+    expect($result)->toEqual(5.537);
 });
 
 it('can convert "18-2.5" from english to metric', function () {
     $result = Distance::fromFeet("18-2.5")->to(Format::METRIC);
     expect($result)->toEqual(5.55);
 });
 
+it('can convert "18-11.75" from english to metric', function () {
+    $result = Distance::fromFeet("18-11.75")->to(Format::METRIC);
+    expect($result)->toEqual(5.785);
+});
+
 it('can convert "18-2.5" from english to metric using toMetric helper', function () {
     $result = Distance::fromFeet("18-2.5")->toMetric();
     expect($result)->toEqual(5.55);