Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through $B2_DONT_EMBED_MANIFEST #5

Closed
wants to merge 1 commit into from
Closed

Pass through $B2_DONT_EMBED_MANIFEST #5

wants to merge 1 commit into from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented May 11, 2024 •
edited
Loading

This is required or the bootstrap of b2 will fail with:

windres --input res.rc --output res.o
/usr/bin/windres: Can't detect architecture.

Minimal version of #4

@Flamefire
Pass through $B2_DONT_EMBED_MANIFEST
10fbb28 
This is required or the bootstrap of b2 will fail with:

> windres --input res.rc --output res.o
> /usr/bin/windres: Can't detect architecture.
jeking3
jeking3 requested changes May 13, 2024
View reviewed changes
Copy link
Owner

@jeking3 jeking3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the change I just merged covers this specific case as well as any other B2_ prefixed environment variables.

@Flamefire
Copy link
Contributor Author

Absolutely, thanks!

Closed by #4

@jeking3 jeking3 closed this May 13, 2024
@Flamefire Flamefire deleted the patch-2 branch May 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeking3 jeking3 jeking3 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flamefire @jeking3