Refresh Server Info #1402
Merged
Refresh Server Info #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LePips
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
This seems okay for now. I've only pushed a small workaround to reset the UserSession which will make future view models use the updated information so we don't need to wait for the next restart.
But UserSession needs more architectural consideration so that it can update its own values and the UI picks up on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working to resolve #1389, looking through where server information is set this is the partial solution I came up with. It's not ideal as the user won't see the name change until after relaunching the app so pointers on where to put this would be appreciated!
There is also a
TODOin ServerCheckViewModel that says "Also server stuff", what needs to be done to resolve the todo? I can fill it out since I'm already touching that file.