-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vimu external player support and fix some MX Player issues #1719
Add Vimu external player support and fix some MX Player issues #1719
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The external player support is planned for removal. The existing code for it will be kept "as-is" without any new features added to it. So unfortunately we won't be merging this pull request. When the playback rewrite (#1057) is done, external player support will be entirely removed.
@nielsvanvelzen Yeah already heard about this from thornbill and noted my concerns on this decision. So i can only plead to please keep this option and allow me to get my PR merged? It does not really affect any of the other parts so why not just keep the option? Here are some reasons users actually need this feature:
I checked Emby and even they still keep the external player option, so i wonder why would you remove a good option that seems reasonable to maintain? |
Right now external players work (although the code is quite a hack..) but with the rewritten playback code it doesn't. So sure, merging this now is possible, but in the end it will be removed. That's why I preferred not to change it. I'm well aware that with the current releases video playback isn't perfect. The arguments about incorrect codecs, lack of advanced substation subtitles support are all things that will be fixed in the rewritten code together with options to manually change supported codecs (and thus when transcoding will happen). I'll review this PR and we'll merge it, but if there's any issues with it after release the PR will be reverted as I have no interest in fixing potential bugs with it. |
I don't expect it to-be perfect that is the point, not even Plex manages to get to what i want. That's why i explicitly picked Jellyfin over Emby/Plex, since i can just use a external player which fixes most of my issues and send in PR for issues i can fix. Yet as noted the biggest issue is that the default Jellyfin player will "probably" never be able to support stuff like dolby VS10. It also seems a lot of the streaming boxes out there, also have custom hacks/fixes in there internal player (gallery3d app) to circumvent issues that are specific to the chip. We also know most vendors are just too lazy to try backport those fixes to Exoplayer, so users will be left stranded and either cant use Jellyfin or must accept the hardware issues of there device.
Fair enough, thanks! |
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/ui/playback/ExternalPlayerActivity.java
Outdated
Show resolved
Hide resolved
e96d95b
to
143d34e
Compare
ok all fixed |
143d34e
to
de7d72d
Compare
* add Vimu external player support * add better title support on external playback * add filename to mx player extras * fix mPosition conversion to int * add detection for playback completion
de7d72d
to
e180106
Compare
Changes