Rewrite media queuing #3833
Merged
Rewrite media queuing #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
nielsvanvelzen
force-pushed
the
playback-queue-service
branch
from
8217c16
to
deb346b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| suspend fun getItem(index: Int): QueueEntry? | ||
| /** | ||
| * Add a supplier of queue items to the end of the queue. Will automatically fetch the first item if there is no current entry. |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
| ): QueueEntry? | ||
|
|
||
| /** | ||
| * Get the next n entries in the queue. Where n is the amount to fetch. The returned collection may be smaller or empty depending on |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style. Warning
crobibero
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the architecture of playback queues to have a single queue(service) per playback manager which is filled with entries via suppliers. This is required for some upcoming functionality to support more upcoming functionality that is needed for lyric loading (and eventually media segments and other fancy stuff).
Changes
QueuetoQueueSupplierQueueServicewhich is based on the previousQueueStatePlaybackManagerBuilderMediaStreamStatetoMediaStreamServicePlaybackManagerBuilderIssues
Part of #1057