Add flow support for elements #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now all elements were set before they needed to be read. While working on lyrics support this became a limitation. For lyrics we'll fetch them when the song starts playing instead of preloading it. The UI would need to be notified of the lyrics being added, therefor I've added a new API to the ElementsContainer that can return a flow. To avoid caching a bunch of stateflows this implementation uses a single internal flow that emits for each element update, this then prompts the returned flows to update themself.
Unlike the simple getters we do not have a requiredFlow, instead it will always emit either a value or null. I may change this in the future.
Changes
Issues
Part of #1057