Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iis.md #1220

Closed
wants to merge 2 commits into from
Closed

Update iis.md #1220

wants to merge 2 commits into from

Conversation

kimboslice99
Copy link
Contributor

Long running streams may freeze due to limits within IIS, I have added a command to prevent this issue.

Setting httpVersion wasn't necessary so that has been removed.

Long running streams may freeze due to limits within IIS, I have added a command to prevent this issue.

Setting httpVersion wasn't necessary so that has been removed.
Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the HTTP version needs to be set for websockets to work properly. Can you please check?

@kimboslice99
Copy link
Contributor Author

While this may be true for other proxies it does not appear to be the case for ARR. The default is PassThrough which has no issues

Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough bout IIS to validate this properly but from a quick look at the docs it seems fine.

after more than 2 years at 25 and hundreds of devices working fine I finally discovered one that still had hiccups for whatever reason.

drop this another 10 bytes should ensure users dont have to tolerate freezing issues
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 34be1eb7b9757bde87e8a9417b781e77a9fd995c
Status ✅ Deployed!
Preview URL https://1d12c528.jellyfin-org.pages.dev
Type 🔀 Preview

@felix920506
Copy link
Member

We decided to remove IIS from the docs entirely since none of the active team members / community members know how to use it.

@kimboslice99
Copy link
Contributor Author

I am the original writer of that doc and am well experienced with IIS. You can look in my repos for proof of this.

How could I become a community member? I could fulfill any need for IIS debugging or general documentation.

@felix920506
Copy link
Member

@kimboslice99 the best way would be to just hang out and help out on our forum or in our chat rooms and you will be recognized after a while of regular activity. https://jellyfin.org

@kimboslice99
Copy link
Contributor Author

I’ve been involved in the Jellyfin ecosystem for a couple of years now, with a handful of small commits across the project.

I am surprised that forum or chatroom activity is required to contribute, even for something like writing documentation. This feels like an unusual requirement—most projects I’ve seen focus primarily on the contributions themselves, not external factors like forum presence.

Why is this a part of the process? It feels restrictive and seems to go against GitHub’s open and collaborative nature.

@JPVenson
Copy link
Member

The forum and chat is by no means required to contribute, but its where all core members are usually present and discuss topics on a day to day bases. It would have made no difference if you are in chat or not, the whole IIS documentation was a very hot discussed topic in the first place if you remember.

We (the team) made the decision to put the docs up and see how it goes but we came to the conclusion that its not a platform we want to support officially (hence the removal of the docs) because as felix said, no person assoicated with the project is able to support it, mainly in chat where the vast majority of support questions come up.

We have no way of reviewing this kind of change and for community members we also usually assume some sort of active discussion in chat for day-to-day topics but then you would need to be online most of the time if/when such questions would come up.

In the end, if nobody really uses it we still need to support it and it adds no benefit and as soon as more people use it, we can still not support it because nobody from the team uses it. I hope you see our issue with it.

I know that this might not be the most satisfying answer i can give you, but we cannot do it all. Regardless i would be happy if you would join our matrix/discord server and engage with our community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants