Remove windows-32 ffmpeg download
#376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardsondev
changed the title
windows-32 ffmpeg download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When
os.arch()==ia32we try to downloadwindows-32ffmpeg but on ffbinaries it no longer exists: https://ffbinaries.com/api/v1/version/latestFrom investigation, this is by design on their end and they will not provide 32-bit Windows binaries anymore.
On the Windows 11 x64 machine I am building on,
os.arch()is returningia32andos.platform()returnswin32which is leading to ffmpeg to not automatically download as it attempts to download thewindows-32binary.os.arch()andos.platform()from console.log:But this is a 64-bit machine:
This change
This PR is removing
windows-32ffmpeg downloading since the link doesn't exist anymore. On my local Windows 11 x64 machine, it is now successfully downloading ffmpeg automatically fromwindows-64.We could also find a new source for 32-bit Windows ffmpeg but from my investigation, the usage of 32-bit Windows is low.
At least on Steam, 32-bit Windows is only 0.18% of Windows machines: https://store.steampowered.com/hwsurvey/
0.18% =
(0.12+0.05)*100/96.68Tests