Skip to content

Commit

Permalink
Merge pull request #545 from yelhouti/fix-start-gitlab
Browse files Browse the repository at this point in the history
fix: allow default to use github when unable to parse gitUrl
  • Loading branch information
jenkins-x-bot authored Sep 4, 2024
2 parents bad3021 + 4a03450 commit 6f1f7f1
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkg/cmd/start/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,8 @@ func (o *Options) createLighthouseJob(jobName string, cfg *config.Config) error
}
gitServerURL = gitInfo.HostURL()
} else {
gitInfo, err = giturl.ParseGitURL(gitServerURL)
if err != nil {
return fmt.Errorf("failed to parse git server URL %s: %w", gitServerURL, err)
}
// if failed to parse we ignore and try use default values with github...
gitInfo, _ = giturl.ParseGitURL(gitServerURL)
}

gitKind := sr.Spec.ProviderKind
Expand Down

0 comments on commit 6f1f7f1

Please sign in to comment.