Skip to content

Commit

Permalink
fix: run_if_changed test
Browse files Browse the repository at this point in the history
When checking if the issue jenkins-x/jx#8477 was still valid I noticed that this test
a) Tested the wrong thing
b) Expected the wrong result

Now fixed
  • Loading branch information
msvticket committed Dec 19, 2023
1 parent 6f18e6a commit 9d0a12d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/plugins/trigger/generic-comment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ func TestHandleGenericComment(t *testing.T) {
name: "explicit /test for RunIfChanged job that doesn't need to run",

Author: "trusted-member",
Body: "/test pull-jeb",
Body: "/test jeb",
State: "open",
IsPR: true,
Presubmits: map[string][]job.Presubmit{
Expand All @@ -729,7 +729,7 @@ func TestHandleGenericComment(t *testing.T) {
},
},
},
ShouldBuild: false,
ShouldBuild: true,
},
{
name: "/test all of run_if_changed job that has passed and needs to run",
Expand Down

0 comments on commit 9d0a12d

Please sign in to comment.