feat: More tracing logs

pkg/jobutil/filter.go

@@ -80,6 +80,7 @@ func FilterPresubmits(filter Filter, changes job.ChangedFilesProvider, branch st
 	for _, presubmit := range presubmits {
 		matches, forced, defaults := filter(presubmit)
 		if !matches {
+			logger.WithField("presubmit", presubmit).Trace("doesn't match command filter")
 			continue
 		}
 		shouldRun, err := presubmit.ShouldRun(branch, changes, forced, defaults)

pkg/plugins/trigger/generic-comment.go

@@ -44,12 +44,12 @@ func handleGenericComment(c Client, trigger *plugins.Trigger, gc scmprovider.Gen
 	if commentAuthor == botName {
 		c.Logger.Warn("Comment is made by the bot, for production installs it is recommended to use a different bot user account that your personal one")
 	}
-
+	c.Logger.WithField("event", gc).Trace("Generic comment event")
 	pr, err := c.SCMProviderClient.GetPullRequest(org, repo, number)
 	if err != nil {
 		return err
 	}
-	c.Logger.Tracef("Fetched pull request: %+v", pr)
+	c.Logger.WithField("pull_request", pr).Trace("Fetched pull request")
 
 	// Skip untrusted users comments.
 	trusted, err := TrustedUser(c.SCMProviderClient, trigger, commentAuthor, org, repo)

pkg/scmprovider/pull_requests.go

@@ -20,6 +20,7 @@ type MergeDetails struct {
 func (c *Client) GetPullRequest(owner, repo string, number int) (*scm.PullRequest, error) {
 	ctx := context.Background()
 	fullName := c.repositoryName(owner, repo)
+	// Isn't pr.Base.Ref populated?
 	pr, _, err := c.client.PullRequests.Find(ctx, fullName, number)
 	if err != nil {
 		return nil, err