Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for securityContext in helm chart #1624

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/lighthouse/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ OS := $(shell uname)

HELMDOCS := $(GOPATH)/bin/helm-docs
$(HELMDOCS):
pushd /tmp; $(GO_MOD) get -u github.com/norwoodj/helm-docs/cmd/[email protected]; popd
pushd /tmp; $(GO_MOD) install github.com/norwoodj/helm-docs/cmd/[email protected]; popd

build: clean $(HELMDOCS)
rm -rf requirements.lock
Expand Down
56 changes: 35 additions & 21 deletions charts/lighthouse/README.md

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions charts/lighthouse/templates/foghorn-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ spec:
value: {{ quote $pval }}
{{- end }}
{{- end }}
securityContext:
{{ toYaml .Values.foghorn.containerSecurityContext | indent 12 }}
resources:
{{ toYaml .Values.foghorn.resources | indent 12 }}
volumeMounts:
Expand Down Expand Up @@ -123,3 +125,7 @@ spec:
tolerations:
{{ toYaml . | indent 8 }}
{{- end }}
{{- with .Values.foghorn.securityContext }}
securityContext:
{{ toYaml . | indent 8 }}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ spec:
- name: {{ $pkey }}
value: {{ quote $pval }}
{{- end }}
securityContext:
{{- toYaml .Values.jenkinscontroller.containerSecurityContext | nindent 12 }}
resources:
{{- toYaml .Values.jenkinscontroller.resources | nindent 12 }}
volumeMounts:
Expand All @@ -63,4 +65,6 @@ spec:
{{- toYaml .Values.jenkinscontroller.affinity | nindent 8 }}
tolerations:
{{- toYaml .Values.jenkinscontroller.tolerations | nindent 8 }}
securityContext:
{{- toYaml .Values.jenkinscontroller.securityContext | nindent 8 }}
{{- end }}
6 changes: 6 additions & 0 deletions charts/lighthouse/templates/keeper-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ spec:
- secretRef:
name: jx-boot-job-env-vars
optional: true
securityContext:
{{ toYaml .Values.keeper.containerSecurityContext | indent 10 }}
resources:
{{ toYaml .Values.keeper.resources | indent 10 }}
volumeMounts:
Expand Down Expand Up @@ -136,3 +138,7 @@ spec:
tolerations:
{{ toYaml . | indent 8 }}
{{- end }}
{{- with .Values.keeper.securityContext }}
securityContext:
{{ toYaml . | indent 8 }}
{{- end }}
4 changes: 4 additions & 0 deletions charts/lighthouse/templates/tekton-controller-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ spec:
- secretRef:
name: jx-boot-job-env-vars
optional: true
securityContext:
{{- toYaml .Values.tektoncontroller.containerSecurityContext | nindent 12 }}
resources:
{{- toYaml .Values.tektoncontroller.resources | nindent 12 }}
terminationGracePeriodSeconds: {{ .Values.tektoncontroller.terminationGracePeriodSeconds }}
Expand All @@ -59,4 +61,6 @@ spec:
{{- toYaml .Values.tektoncontroller.affinity | nindent 8 }}
tolerations:
{{- toYaml .Values.tektoncontroller.tolerations | nindent 8 }}
securityContext:
{{- toYaml .Values.tektoncontroller.securityContext | nindent 8 }}
{{- end }}
7 changes: 7 additions & 0 deletions charts/lighthouse/templates/webhooks-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ spec:
periodSeconds: {{ .Values.webhooks.readinessProbe.periodSeconds }}
successThreshold: {{ .Values.webhooks.readinessProbe.successThreshold }}
timeoutSeconds: {{ .Values.webhooks.readinessProbe.timeoutSeconds }}
securityContext:
{{ toYaml .Values.webhooks.containerSecurityContext | indent 12 }}
resources:
{{ toYaml .Values.webhooks.resources | indent 12 }}
volumeMounts:
Expand Down Expand Up @@ -165,3 +167,8 @@ spec:
tolerations:
{{ toYaml . | indent 8 }}
{{- end }}
{{- with .Values.webhooks.securityContext }}
securityContext:
{{ toYaml . | indent 8 }}
{{- end }}

64 changes: 47 additions & 17 deletions charts/lighthouse/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ externalPlugins:
name: lighthouse-webui-plugin

gcJobs:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# gcJobs.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# gcJobs.maxAge -- Max age from which `LighthouseJob`s will be deleted
Expand Down Expand Up @@ -120,7 +120,7 @@ gcJobs:
pullPolicy: "{{ .Values.image.pullPolicy }}"

webhooks:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# webhooks.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# webhooks.replicaCount -- Number of replicas
Expand Down Expand Up @@ -197,6 +197,12 @@ webhooks:
# webhooks.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the webhooks pods
tolerations: []

# webhooks.securityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the webhooks pods
securityContext: {}

# webhooks.containerSecurityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the webhooks containers
containerSecurityContext: {}

ingress:
# webhooks.ingress.enabled -- Enable webhooks ingress
enabled: false
Expand All @@ -222,7 +228,7 @@ webhooks:
customDeploymentTriggerCommand: ""

foghorn:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# foghorn.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# foghorn.replicaCount -- Number of replicas
Expand Down Expand Up @@ -261,9 +267,15 @@ foghorn:
# foghorn.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the foghorn pods
tolerations: []

# foghorn.securityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the foghorn pods
securityContext: {}

# foghorn.containerSecurityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the foghorn containers
containerSecurityContext: {}


tektoncontroller:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# tektoncontroller.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# tektoncontroller.dashboardURL -- the dashboard URL (e.g. Tekton dashboard)
Expand Down Expand Up @@ -302,6 +314,12 @@ tektoncontroller:
# tektoncontroller.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the tekton controller pods
tolerations: []

# tektoncontroller.securityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the tekton controller pods
securityContext: {}

# tektoncontroller.containerSecurityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the tekton controller containers
containerSecurityContext: {}

resources:
# tektoncontroller.resources.limits -- Resource limits applied to the tekton controller pods
limits:
Expand All @@ -318,7 +336,7 @@ tektoncontroller:
annotations: {}

jenkinscontroller:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# jenkinscontroller.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# jenkinscontroller.jenkinsURL -- The URL of the Jenkins instance
Expand All @@ -330,48 +348,54 @@ jenkinscontroller:
# jenkinscontroller.jenkinsToken -- The token for authenticating the Jenkins user
jenkinsToken:

# jenkinscontroller.terminationGracePeriodSeconds -- Termination grace period for tekton controller pods
# jenkinscontroller.terminationGracePeriodSeconds -- Termination grace period for jenkins controller pods
terminationGracePeriodSeconds: 180

image:
# jenkinscontroller.image.repository -- Template for computing the Jenkins controller docker image repository
repository: "{{ .Values.image.parentRepository }}/lighthouse-jenkins-controller"

# jenkinscontroller.image.tag -- Template for computing the tekton controller docker image tag
# jenkinscontroller.image.tag -- Template for computing the jenkins controller docker image tag
tag: "{{ .Values.image.tag }}"

# jenkinscontroller.image.pullPolicy -- Template for computing the tekton controller docker image pull policy
# jenkinscontroller.image.pullPolicy -- Template for computing the jenkins controller docker image pull policy
pullPolicy: "{{ .Values.image.pullPolicy }}"

# jenkinscontroller.podAnnotations -- Annotations applied to the tekton controller pods
# jenkinscontroller.podAnnotations -- Annotations applied to the jenkins controller pods
podAnnotations: {}

# jenkinscontroller.nodeSelector -- [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) applied to the tekton controller pods
# jenkinscontroller.nodeSelector -- [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) applied to the jenkins controller pods
nodeSelector: {}

# jenkinscontroller.affinity -- [Affinity rules](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity) applied to the tekton controller pods
# jenkinscontroller.affinity -- [Affinity rules](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity) applied to the jenkins controller pods
affinity: {}

# jenkinscontroller.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the tekton controller pods
# jenkinscontroller.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the jenkins controller pods
tolerations: []

# jenkinscontroller.securityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the jenkins controller pods
securityContext: {}

# jenkinscontroller.containerSecurityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the jenkins controller containers
containerSecurityContext: {}

resources:
# jenkinscontroller.resources.limits -- Resource limits applied to the tekton controller pods
# jenkinscontroller.resources.limits -- Resource limits applied to the jenkins controller pods
limits:
cpu: 100m
memory: 256Mi

# jenkinscontroller.resources.requests -- Resource requests applied to the tekton controller pods
# jenkinscontroller.resources.requests -- Resource requests applied to the jenkins controller pods
requests:
cpu: 80m
memory: 128Mi

# jenkinscontroller.service -- Service settings for the tekton controller
# jenkinscontroller.service -- Service settings for the jenkins controller
service:
annotations: {}

keeper:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# keeper.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# keeper.statusContextLabel -- Label used to report status to git provider
Expand Down Expand Up @@ -446,8 +470,14 @@ keeper:
# keeper.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the keeper pods
tolerations: []

# keeper.securityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the keeper pods
securityContext: {}

# keeper.containerSecurityContext -- [Security Context](https://kubernetes.io/docs/tasks/configure-pod-container/security-context/) applied to the keeper containers
containerSecurityContext: {}

poller:
# logLevel -- The logging level: trace, debug, info, warn, error, fatal
# poller.logLevel -- The logging level: trace, debug, info, warn, error, panic, fatal
logLevel: "info"

# poller.enabled -- Whether to enable or disable the poller component
Expand Down
Loading