[JENKINS-75157] Bitbucket client fail to retrieve resource with HTTP 404 for bitbucket server #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfalco79
commented
Jan 18, 2025
| .set("blame", false) | ||
| .expand(); | ||
| String response = getRequest(url); | ||
| // TODO deserialize response... |
There was a problem hiding this comment.
@KalleOlaviNiemitalo could you help me to understand the response of bitbucket server?
It's not clear what return. Do you have an example?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .set("type", true) | ||
| .set("blame", false) | ||
| .expand(); | ||
| String response = getRequest(url); |
Check notice
Code scanning / CodeQL
Unread local variable Note
src/test/java/com/cloudbees/jenkins/plugins/bitbucket/filesystem/BitbucketSCMFileTest.java
Dismissed
Show dismissed
Hide dismissed
nfalco79
force-pushed
the
feature/JENKINS-75157
branch
from
0caaac3 to
9400643
Compare
…404 for bitbucket server (#970) Remove the HttpHost parameter when calling in Apache client as the request could be different than the host configured in jenkins, for example in Bitbucket Server request using mirror link. Rethrow the FileNotFoundException in executeMethod instead of encapsulate into other exception to respect the SCMFile interface. Rewrote the BitbucketSCMFile logic to not assume the SCMFile.type but resolve at runtime when needed.
nfalco79
force-pushed
the
feature/JENKINS-75157
branch
from
9400643 to
2e71525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the HttpHost parameter when calling in Apache client as the request could be different than the host configured in jenkins, for example in Bitbucket Server request using mirror link.
Rethrow the FileNotFoundException in executeMethod instead of encapsulate into other exception to respect the SCMFile interface. Rewrote the BitbucketSCMFile logic to not assume the SCMFile.type but resolve at runtime when needed.