Skip to content

Commit

Permalink
Comments spelling (#1672)
Browse files Browse the repository at this point in the history
  • Loading branch information
jsoref authored and vivek committed Feb 26, 2018
1 parent 3beb5db commit b640430
Show file tree
Hide file tree
Showing 79 changed files with 120 additions and 120 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.build
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ RUN mkdir /.npm && chmod 777 /.npm
RUN cd $(npm root -g)/npm \
&& npm install fs-extra \
&& sed -i -e s/graceful-fs/fs-extra/ -e s/fs\.rename/fs.move/ ./lib/utils/rename.js
# Update to latest version so optional dependancies + shrinkwrap work
# Update to latest version so optional dependencies + shrinkwrap work
RUN npm install -g [email protected]

#=============================================
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Core Web infrastructure that bootstraps BlueOcean UI and integrates REST API cor
## Building and running

At a minimum you will need a JVM and Maven installed, if you are doing active JavaScript development,
you may want to install NodeJS, but it is not a requirement as the `frontent-maven-plugin` will install
you may want to install NodeJS, but it is not a requirement as the `frontend-maven-plugin` will install
the correct version of Node locally for each plugin to build and develop with.

## Build everything (from root directory)
Expand Down
2 changes: 1 addition & 1 deletion bin/cleanInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function removeAndInstall(pathToProject, lib, version, callback) {
install(lib + '@' + version, callback);
}

//remove folder Syncronously
//remove folder Synchronously
function deleteFolderRecursive(path) {
if (fs.existsSync(path)) {
fs.readdirSync(path).forEach(function (file, index) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public abstract class BitbucketApiFactory implements ExtensionPoint {
*
* Before calling this method, clients must ensure {@link #handles(String)} is called first and returned true
*
* @param apiUrl API url (host url) of bitbucket server or cloud. e.g. https://mybitcuketserver.com/
* @param apiUrl API url (host url) of bitbucket server or cloud. e.g. https://mybitbucketserver.com/
* @param credentials {@link StandardUsernamePasswordCredentials}
* @return {@link BitbucketApi} instance
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public void createAndList() throws Exception {
assertEquals("My Server", server.get("name"));
assertEquals(apiUrl, server.get("apiUrl"));

//get this paritular endpoint
//get this particular endpoint
server = request()
.status(200)
.jwtToken(token)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
public abstract class PageStatePreloader implements ExtensionPoint {

/**
* Get the JavaScript object graph path at shiwh the state is to be stored.
* @return The JavaScript object graph path at shiwh the state is to be stored.
* Get the JavaScript object graph path at which the state is to be stored.
* @return The JavaScript object graph path at which the state is to be stored.
*/
@Nonnull
public abstract String getStatePropertyPath();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,16 @@ public void extensionCanOverrideBehaviourTest() throws Exception {

Boolean originalConfig = BlueOceanConfigFactory.getConfig(BlueOceanConfig.ORGANIZATION_ENABLED, Boolean.class);

assertThat("Overriden extension point should have been called", BlueOceanTestConfigurationFactory.loaded, equalTo(true));
assertThat("Overridden extension point should have been called", BlueOceanTestConfigurationFactory.loaded, equalTo(true));

//Check reload and override
BlueOceanTestConfigurationFactory.setValue = !originalConfig;
BlueOceanTestConfigurationFactory.loaded = false;

Boolean overridenConfig = BlueOceanConfigFactory.getConfig(BlueOceanConfig.ORGANIZATION_ENABLED, Boolean.class);
Boolean overriddenConfig = BlueOceanConfigFactory.getConfig(BlueOceanConfig.ORGANIZATION_ENABLED, Boolean.class);

assertThat("Configuration should have been reloaded", BlueOceanTestConfigurationFactory.loaded, equalTo(true));
assertThat("Configuration should have been overriden", originalConfig, not(equalTo(overridenConfig)));
assertThat("Configuration should have been overridden", originalConfig, not(equalTo(overriddenConfig)));

}

Expand Down
2 changes: 1 addition & 1 deletion blueocean-core-js/src/js/ToastService.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class ToastService {
* onActionClick: function, callback to invoke when action link is clicked
* onDismiss: function, callback to invoke when toast is dismissed (immediately, or after timeout)
* dismissDelay: number, duration in millis after which to auto-dismiss this Toast
* id: unique identifier (optional, will be autogenerated if ommitted)
* id: unique identifier (optional, will be autogenerated if omitted)
* }
* @returns {number} unique ID of toast
*/
Expand Down
2 changes: 1 addition & 1 deletion blueocean-core-js/src/js/i18n/bundle-startup.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export function execute(done, bundleConfig) {
done();
}
} else {
logger.warn(`Unexpected error finding pluging info for plugin ${bundleConfig.hpiPluginId}. There should be a preloaded jsExtensions entry.`);
logger.warn(`Unexpected error finding plugin info for plugin ${bundleConfig.hpiPluginId}. There should be a preloaded jsExtensions entry.`);
done();
}
} else {
Expand Down
6 changes: 3 additions & 3 deletions blueocean-core-js/src/js/services/BunkerService.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ export class BunkerService {
}

/**
* Extracts the key to store the daata under out of the object
* Extracts the key to store the data under out of the object
*
* Default impl uses the self href link in BlueOcuean objects.
* Default impl uses the self href link in BlueOcean objects.
*
* @param {object} data Data to be stored once it has been passed through
* [@link bunkerMapper]
Expand Down Expand Up @@ -62,7 +62,7 @@ export class BunkerService {
* It uses the [@link bunkerKey] and [@link bunkerMapper] to generate the key/value
* to be stored.
*
* @param {Object} item Raw data from extenal source.
* @param {Object} item Raw data from external source.
* @returns {Object} item mapped by [@link bunkerMapper]. It is also a mobx computed value.
*/
@action
Expand Down
8 changes: 4 additions & 4 deletions blueocean-core-js/src/js/services/Pager.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Fetch } from '../fetch';
*
* @export
* @param {string} url - Base url to paginate.
* @returns {function} - Function that provides pagincated urls.
* @returns {function} - Function that provides paginated urls.
*/
export function paginateUrl(url) {
const sep = url.indexOf('?') >= 0 ? '&' : '?';
Expand All @@ -20,14 +20,14 @@ export function paginateUrl(url) {
* inserts them into the [@link BunkerService], and stores the href from the data.
*
* MobX computes a data field from the hrefs backed by the backend cache. This allows for SSE events
* to be proporgated to the pager.
* to be propagated to the pager.
*
* @export
* @class Pager
*/
export class Pager {
/**
* List of deisplayed items hrefs.
* List of displayed items hrefs.
*/
@observable hrefs = [];
/**
Expand Down Expand Up @@ -62,7 +62,7 @@ export class Pager {
/**
* Creates an instance of Pager and fetches the first page.
*
* @param {string} url - Base url of collectin to fetch
* @param {string} url - Base url of collection to fetch
* @param {number} pageSize - Page size to fetch during one load.
* @param {BunkerService} bunker - Data store
* @param {UrlProvider} [urlProvider=paginateUrl]
Expand Down
6 changes: 3 additions & 3 deletions blueocean-core-js/src/js/services/PagerService.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* This service manages the various instances of pagers that currently exist.
*
* TODO: Currently a new pager is created for any new list of items to be paged. Cleanup may be
* required to stop memory leakes. However Pagers don't store more data so this may not be an issue.'
* required to stop memory leaks. However Pagers don't store more data so this may not be an issue.'
*
* @export
* @class PagerService
Expand All @@ -16,10 +16,10 @@ export class PagerService {
/**
* Registers a pager with the PagerService.
*
* Namespacing strings is prefered to stop colisions. E.g. Activity/$org-$pipeline.
* Namespacing strings is prefered to stop collisions. E.g. Activity/$org-$pipeline.
*
* @param {any} key - Key to register the pager under.
* @param {Pager} pager - pager to regiser.
* @param {Pager} pager - pager to register.
*/
registerPager(key, pager) {
if (this._pagerMap.has(key)) {
Expand Down
2 changes: 1 addition & 1 deletion blueocean-core-js/src/js/services/PipelineService.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import utils from '../utils';
import { BunkerService } from './BunkerService';
import { action } from 'mobx';
/**
* This class handles pipeline related data. This includes pipelines, branches and pullrequeusts as they are
* This class handles pipeline related data. This includes pipelines, branches and pullrequests as they are
* all pipelines in the backend.
*
* @export
Expand Down
4 changes: 2 additions & 2 deletions blueocean-core-js/src/less/variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

.action-button-colors {

// default (light) themeing
// default (light) theming

.svg-icon {
// Default fill for basic shapes, can be undone with a <g fill="none">
Expand All @@ -31,7 +31,7 @@
}
}

// dark themeing
// dark theming

&.dark {
.btn {
Expand Down
2 changes: 1 addition & 1 deletion blueocean-core-js/test/js/ToastService-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('ToastService', () => {
assert.isOk(toast.id);
});

it('adds a new toast and perserves ID if necessary', () => {
it('adds a new toast and preserves ID if necessary', () => {
toastService.newToast({
id: 12345,
text: 'Hello World',
Expand Down
2 changes: 1 addition & 1 deletion blueocean-core-js/test/js/utils/TimeManager-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe("TimeManager", () => {

const aTtimeManager = new TimeManager();

it('/ Supprts Client GMT-7 running job - pause state', () => {
it('/ Supports Client GMT-7 running job - pause state', () => {
const skewMillis = -7118377;
aTtimeManager.currentTime = () => moment(1485441519326);
const {
Expand Down
10 changes: 5 additions & 5 deletions blueocean-dashboard/reports/junit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</testcase>
<testcase classname="UrlUtils buildPipelineUrl should build the baseUrl for 3-level nested pipeline" name="UrlUtils buildPipelineUrl should build the baseUrl for 3-level nested pipeline" time="0">
</testcase>
<testcase classname="UrlUtils buildRunDetailsUrl should build the baseUrl if tabName ommitted" name="UrlUtils buildRunDetailsUrl should build the baseUrl if tabName ommitted" time="0.001">
<testcase classname="UrlUtils buildRunDetailsUrl should build the baseUrl if tabName omitted" name="UrlUtils buildRunDetailsUrl should build the baseUrl if tabName omitted" time="0.001">
</testcase>
<testcase classname="UrlUtils buildRunDetailsUrl should build the full url with tab name" name="UrlUtils buildRunDetailsUrl should build the full url with tab name" time="0">
</testcase>
Expand All @@ -20,19 +20,19 @@
</testcase>
<testcase classname="UrlUtils calculate calculateNodeBaseUrl should build the url no multibranch" name="UrlUtils calculate calculateNodeBaseUrl should build the url no multibranch" time="0.001">
</testcase>
<testcase classname="UrlUtils calculate calculateNodeBaseUrl should build the url with mutibranch" name="UrlUtils calculate calculateNodeBaseUrl should build the url with mutibranch" time="0">
<testcase classname="UrlUtils calculate calculateNodeBaseUrl should build the url with multibranch" name="UrlUtils calculate calculateNodeBaseUrl should build the url with multibranch" time="0">
</testcase>
<testcase classname="UrlUtils double encode branch name in nodeBaseUrl should build the url multibranch" name="UrlUtils double encode branch name in nodeBaseUrl should build the url multibranch" time="0.001">
</testcase>
<testcase classname="UrlUtils build classicConfigUrl should build the url for classic config" name="UrlUtils build classicConfigUrl should build the url for classic config" time="0.001">
</testcase>
<testcase classname="UrlUtils calculate calculateStepsBaseUrl should build the url with node" name="UrlUtils calculate calculateStepsBaseUrl should build the url with node" time="0.001">
</testcase>
<testcase classname="UrlUtils calculate calculateStepsBaseUrl should build the url with mutibranch and no node" name="UrlUtils calculate calculateStepsBaseUrl should build the url with mutibranch and no node" time="0">
<testcase classname="UrlUtils calculate calculateStepsBaseUrl should build the url with multibranch and no node" name="UrlUtils calculate calculateStepsBaseUrl should build the url with multibranch and no node" time="0">
</testcase>
<testcase classname="UrlUtils calculate calculateRunLogURLObject should build the urlObject no multibranch" name="UrlUtils calculate calculateRunLogURLObject should build the urlObject no multibranch" time="0.001">
</testcase>
<testcase classname="UrlUtils calculate calculateRunLogURLObject should build the urlObject with mutibranch" name="UrlUtils calculate calculateRunLogURLObject should build the urlObject with mutibranch" time="0">
<testcase classname="UrlUtils calculate calculateRunLogURLObject should build the urlObject with multibranch" name="UrlUtils calculate calculateRunLogURLObject should build the urlObject with multibranch" time="0">
</testcase>
</testsuite>
<testsuite name="pipeline graph data converter /" tests="12" errors="0" failures="0" skipped="0" timestamp="2017-07-02T05:36:46" time="13.35">
Expand Down Expand Up @@ -184,7 +184,7 @@
<testsuite name="Enum" tests="2" errors="0" failures="0" skipped="0" timestamp="2017-07-02T05:37:18" time="0.573">
<testcase classname="Enum construction should populate the keys and values" name="Enum construction should populate the keys and values" time="0.002">
</testcase>
<testcase classname="Enum values should return an erray with all values" name="Enum values should return an erray with all values" time="0">
<testcase classname="Enum values should return an array with all values" name="Enum values should return an array with all values" time="0">
</testcase>
</testsuite>
<testsuite name="RunDetailsArtifacts" tests="2" errors="0" failures="0" skipped="0" timestamp="2017-07-02T05:37:16" time="3.041">
Expand Down
6 changes: 3 additions & 3 deletions blueocean-dashboard/src/main/js/components/Capability.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class CapabilityRecord extends Record({ classNames: [] }) {
}

/**
* capabilityStore is a enchances components to inject capabilities for
* capabilityStore is a enhances components to inject capabilities for
* a given class.
*
* Usage: capabilityStore(classFunction)(React.Component) where
Expand All @@ -27,7 +27,7 @@ export class CapabilityRecord extends Record({ classNames: [] }) {
* props => props.pipeline._class
* props => [props.pipeline._class, props.favoriteData._class]
*
* capabilityStore will inject "capabilities" as a property into the componenet
* capabilityStore will inject "capabilities" as a property into the component
* so you need to add "capabilities: object" to propTypes. capabilities.has(MULTIBRANCH)
* can be called to find out if a capability is supported. A list of capabilities is in the
* Capabilities.js file.
Expand Down Expand Up @@ -87,7 +87,7 @@ export const capabilityStore = classesFunction => ComposedComponent => class ext
const { capabilities } = this.state;

// Early out. Doing it here means we don't have to do it in
// the composed componenet
// the composed component
let classesMap = classesFunction(this.props);
if (classesMap === undefined || classesMap === null) {
throw new Error('capabilityStore function did not find class in props.');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export function convertJenkinsNodeGraph(jenkinsGraph, isCompleted, skewMillis) {
// Filter out any edges to missing nodes
allEdges.filter(([src, dest]) => (src in convertedNodeForId && dest in convertedNodeForId));

// Cound edges going to/from each node.
// Count edges going to/from each node.
for (const edgePair of allEdges) {
const dest = edgePair[1];
edgeCountToNode[dest] = edgeCountToNode[dest] + 1;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class Step extends Component {
};
// some ATH hook enhancements
const logConsoleClass = `logConsole step-${step.id}`;
// duration calaculations
// duration calculations
const duration = step.isRunning ? this.durationInMillis : durationInMillis;
logger.debug('duration', duration, step.isRunning);
const time = (<TimeDuration
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class PipelinePager {
*
* @param {BunkerService} bunker - Data store
* @param {object} augmenter augmenter that this pager belongs to.
* @param {object} props Properies that this pager belongs to.
* @param {object} props Properties that this pager belongs to.
*/
constructor(bunker, augmenter, props) {
this.bunker = bunker;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ export const step = {
'_class': 'hudson.model.StringParameterDefinition',
'defaultParameterValue': {
'_class': 'hudson.model.StringParameterValue',
'name': 'this is a string parmeter',
'name': 'this is a string parameter',
'value': 'yeah',
},
'description': 'string parameter desc',
'name': 'this is a string parmeter',
'name': 'this is a string parameter',
'type': 'StringParameterDefinition',
}, {
'_class': 'hudson.model.PasswordParameterDefinition',
Expand Down
2 changes: 1 addition & 1 deletion blueocean-dashboard/src/main/js/util/PromiseDelayUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ function time() {
*
* Note that the delay time is not additive to the original call but ensures a minimum across both calls, e.g.
* 1. If original call takes 250 and delay is 500, Promise will resolve after 500.
* 2. If original call takes 750 and delay is 500, Promise will reoslve after 500.
* 2. If original call takes 750 and delay is 500, Promise will resolve after 500.
*
* Usage:
* getFooAsync()
Expand Down
2 changes: 1 addition & 1 deletion blueocean-dashboard/src/main/js/util/ansi.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import React from 'react';
*
* Result:
* ```
* // Suppoerted code
* // Supported code
* {
* isSelectGraphicRendition: true,
* escapeCode: string, // input
Expand Down
4 changes: 2 additions & 2 deletions blueocean-dashboard/src/main/js/util/logDisplayHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function isRunningNode(item) {

export const getNodesInformation = (nodes) => {
// calculation of information about stages
// nodes in Runing state
// nodes in Running state
const runningNodes = nodes
.filter((item) => isRunningNode(item) && (!item.edges || item.edges.length < 2))
.map((item) => item.id);
Expand Down Expand Up @@ -96,7 +96,7 @@ export const getNodesInformation = (nodes) => {
}
return modelItem;
});
// in case we have all null we will focuse the first node since we assume that this would
// in case we have all null we will focus the first node since we assume that this would
// be the next node to be started
if (queuedNodes.length === nodes.length && !wasFocused && model[0]) {
model[0].isFocused = true;
Expand Down
4 changes: 2 additions & 2 deletions blueocean-dashboard/src/main/less/variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

.action-button-colors {

// default (light) themeing
// default (light) theming

.svg-icon {
// Default fill for basic shapes, can be undone with a <g fill="none">
Expand All @@ -66,7 +66,7 @@
}
}

// dark themeing
// dark theming

&.dark {
.btn {
Expand Down
Loading

0 comments on commit b640430

Please sign in to comment.