Improve Embeds, Major Refactor/Cleanup #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andre601
reviewed
Feb 1, 2025
Comment on lines
+162
to
+165
| StringBuilder descriptionBuilder = new StringBuilder(); | ||
| for (Map.Entry<String, String> entry : matrixConfiguration.getCombination().entrySet()) | ||
| descriptionBuilder.append(String.format("- %s: %s", entry.getKey(), entry.getValue())) | ||
| .append('\n'); |
There was a problem hiding this comment.
Wouldn't it be simpler to use a StringJoiner("\n") here instead of a StringBuilder that will have a trailing newline?
There was a problem hiding this comment.
I just prefer StringBuilder as everyone is able to immediately recognize what it is. Even as someone who is rather experienced with java, I did not initially recognize StringJoiner as being a class in the standard library. But if desired, I could replace it with StringJoiner. I would however personally prefer StringBuilder.
Comment on lines
+194
to
+197
| StringBuilder changesDescription = new StringBuilder(); | ||
| for (String changeEntry : changesList) | ||
| changesDescription.append(changeEntry) | ||
| .append('\n'); |
src/main/java/nz/co/jammehcow/jenkinsdiscord/util/EmbedUtil.java
Outdated
Show resolved
Hide resolved
Signed-off-by: solonovamax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves embeds and a major refactor/cleanup of basically everything.
This improves embeds based off of the suggestions provided via #27
Here's a list of relevant issues
Here are the changes to the embed:
For the refactors/cleanup:
Testing done
Honestly I have no clue how to do testing with Jenkins plugins. Would love feedback for that if tests are needed, however since there were already basically no tests I felt it wasn't super needed.
Submitter checklist