Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70303] Ignore leading and trailing spaces in refspecs #1095

Closed
wants to merge 5 commits into from

Conversation

HimaTeju
Copy link

@HimaTeju HimaTeju commented Jan 14, 2024

JENKINS-70303 - ignore leading and trailing spaces in refspecs

I am using trim() method to remove the leading space characters.

Describe the big picture of your changes here to explain to the maintainers why this pull request should be accepted.
If it fixes a bug or resolves a feature request, include a link to the issue.
The Link to the issue: https://issues.jenkins.io/browse/JENKINS-70303

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • Bug fix (non-breaking change which fixes an issue)

I am using trim() method to remove the leading space characters.
@HimaTeju HimaTeju requested a review from a team as a code owner January 14, 2024 08:09
@github-actions github-actions bot added the tests Automated test addition or improvement label Jan 14, 2024
@MarkEWaite
Copy link
Contributor

Thanks for the pull request. This proposed change introduces a new spotbugs warning. Please refer to the contributing guide where it says:

Please don’t introduce new spotbugs output

Please perform interactive tests of the change as noted in the bug report

Please include the link to the issue in the pull request, instead of leaving the "JENKINS-xxxx" entry blank.

Please add one or more automated tests to confirm the problem can be duplicated in an automated test and that the code change resolves the issue. I've added an initial test in 40224e4 as a beginning. That test fails with JGit before your change and after your change. I'm not sure it is the best test, but it is one test for consideration.

@MarkEWaite MarkEWaite changed the title Fix to JENKINS-70303 [JENKINS-70303] - ignore leading and trailing spaces in refspecs Jan 14, 2024
@MarkEWaite MarkEWaite changed the title [JENKINS-70303] - ignore leading and trailing spaces in refspecs [JENKINS-70303] ignore leading and trailing spaces in refspecs Jan 14, 2024
@MarkEWaite MarkEWaite changed the title [JENKINS-70303] ignore leading and trailing spaces in refspecs [JENKINS-70303] Ignore leading and trailing spaces in refspecs Jan 14, 2024
@MarkEWaite
Copy link
Contributor

@HimaTeju it looks like this is an inactive pull request. Do you plan to work on the concerns that I noted in my earlier comment #1095 (comment) ? If I don't see a response within a week, I'll close this pull request due to inactivity.

@HimaTeju HimaTeju closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants