Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64844] Provide credentials during checkout #1131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mguillem
Copy link

@mguillem mguillem commented Apr 18, 2024

JENKINS-64844 - Provide credentials during checkout

Start support for partially cloned repos

This is a first draft for review to allow to perform checkout using credentials as required for instance when using a blobless clone. Hints about a better way to retrieve the checkout url or to the kind of unit tests that would be possible are welcome.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • New feature (non-breaking change which adds functionality)

Further comments

This is not a complete support for blobless clone, just enough for our case (checkout scm occurs on Kubernetes in an image already containing a max one day old blobless clone of the repo). If something more complete is required to get this support integrated in the code base, please give me some advice on it.

@mguillem mguillem requested a review from a team as a code owner April 18, 2024 14:38
@MarkEWaite MarkEWaite changed the title JENKINS-64844 allow checkout of partially cloned repo [JENKINS-64844] Allow checkout of partially cloned repo Apr 18, 2024
@MarkEWaite MarkEWaite changed the title [JENKINS-64844] Allow checkout of partially cloned repo [JENKINS-64844] Provide credentials during checkout Apr 18, 2024
@mguillem
Copy link
Author

@MarkEWaite can you give me some hints about the failures? mvn install is successful for me locally under linux (both with java 17 and java 21).

@mischoem
Copy link

mischoem commented May 6, 2024

Hi everyone,

Is there any news here yet? My employer would also be very interested in this extension.
Thanks to @mguillem for providing this!

@MarkEWaite
Copy link
Contributor

Hi everyone,

Is there any news here yet? My employer would also be very interested in this extension. Thanks to @mguillem for providing this!

No news from me. I think that the change is moving on the correct path, since it is following the same pattern that was used to add credentials to the git lfs calls. Unfortunately, I don't have the time to do further research on the test failures. @mischoem if you would be willing to investigate the test failures or have someone from your company investigate the test failures, that would be a very good step.

@mischoem even if you can't investigate the test failures, it would be very good for you to deploy an incremental build of this pull request in your environment and share your results. That would give you immediate access to the feature and would provide feedback to me and other maintainers to confirm that the code is working as desired in production

@mischoem
Copy link

Hi everyone,
Is there any news here yet? My employer would also be very interested in this extension. Thanks to @mguillem for providing this!

No news from me. I think that the change is moving on the correct path, since it is following the same pattern that was used to add credentials to the git lfs calls. Unfortunately, I don't have the time to do further research on the test failures. @mischoem if you would be willing to investigate the test failures or have someone from your company investigate the test failures, that would be a very good step.

@mischoem even if you can't investigate the test failures, it would be very good for you to deploy an incremental build of this pull request in your environment and share your results. That would give you immediate access to the feature and would provide feedback to me and other maintainers to confirm that the code is working as desired in production

A little feedback from my side: After testing it seems to work fine

@mguillem mguillem force-pushed the use-credentials-for-checkout-on-blobless-cloned-repo branch from c4765ab to c8a729f Compare July 22, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants