Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JVM crash in plugin BOM testing #1244

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jan 16, 2025

Revert "Add mockito-core javaagent for future Java compatibility"

Causes plugin BOM tests to fail with a JVM crash. Compatibility with a future condition is much less important than having tests that run successfully now.

This reverts commit bfde394.

Testing done

Confirmed that the JVM crash in the plugin BOM is resolved by this change.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Causes plugin BOM tests to fail with a JVM crash.  Compatibility with
a future condition is much less important than having tests that run
successfully now.

This reverts commit bfde394.
@MarkEWaite MarkEWaite requested a review from a team as a code owner January 16, 2025 22:33
@MarkEWaite MarkEWaite added test Automated test addition or improvement chore Reduces maintenance effort by changes not directly visible to users and removed test Automated test addition or improvement labels Jan 16, 2025
@MarkEWaite MarkEWaite changed the title Revert 'Add mockito-core javaagent for future Java compatibility' Fix JVM crash in plugin BOM testing Jan 17, 2025
@MarkEWaite MarkEWaite merged commit 5e76640 into jenkinsci:master Jan 17, 2025
18 checks passed
@MarkEWaite MarkEWaite deleted the fix-bom-test-crash branch January 17, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant