Replacing magic numbers with constant

[hasskell]

Notes

While I was reading though code notice some magic numbers on FIPS password length, nothing really stopping FIPS standards to change password length in future to increase security posture. This will require several modifications in code which is error prone. Replacing magic numbers with MIN_PASSWORD_LENGTH constant.

Testing done

Done testing with mvn clean insatll

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
Running tests for org.jenkins-ci.plugins:mailer:999999-SNAPSHOT
[INFO] Running hudson.tasks.MailAddressResolverTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.094 s -- in hudson.tasks.MailAddressResolverTest
[INFO] Running hudson.tasks.MailSenderTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.247 s -- in hudson.tasks.MailSenderTest
[INFO] Running hudson.tasks.MailerTest
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 133.7 s -- in hudson.tasks.MailerTest
[INFO] Running jenkins.plugins.mailer.FipsModeTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.00 s -- in jenkins.plugins.mailer.FipsModeTest
[INFO] Running jenkins.plugins.mailer.MailerJCasCCompatibilityTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.165 s -- in jenkins.plugins.mailer.MailerJCasCCompatibilityTest
[INFO] Running jenkins.plugins.mailer.tasks.MailAddressFilterTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.073 s -- in jenkins.plugins.mailer.tasks.MailAddressFilterTest
[INFO] Running jenkins.plugins.mailer.tasks.MimeMessageBuilderTest
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.101 s -- in jenkins.plugins.mailer.tasks.MimeMessageBuilderTest
[INFO] Running org.jenkins_ci.plugins.mailer.InjectedTest
[INFO] Tests run: 80, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.083 s -- in org.jenkins_ci.plugins.mailer.InjectedTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 120, Failures: 0, Errors: 0, Skipped: 0

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• [N/A] Link to relevant issues in GitHub or Jira
• [N/A] Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[rsandell]

Perhaps I would have named it something mentioning FiPS to not confuse a first glance reader, but that's just a nit.

[alecharp]

I won't trigger a release for this change, but thank you for the contribution.

[hasskell]

Perhaps I would have named it something mentioning FiPS to not confuse a first glance reader, but that's just a nit.

That makes sense, Ill have another few changes coming up so will address this in upcoming PR

[hasskell]

I won't trigger a release for this change, but thank you for the contribution.

Sure, sure, there is no urgency just a code sanity.