Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable interpolation on different examples #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions declarative-examples/jenkinsfile-examples/mavenDocker.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ pipeline {
* Multiline strings can be used for larger scripts. It is also possible to put scripts in your shared library
* and load them with 'libaryResource'
*/
sh """
sh '''
docker build -t ${IMAGE} .
docker tag ${IMAGE} ${IMAGE}:${VERSION}
docker push ${IMAGE}:${VERSION}
"""
'''
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ node {
echo "Building flavor ${flavor}"

//build your gradle flavor, passes the current build number as a parameter to gradle
sh "./gradlew clean assemble${flavor}Debug -PBUILD_NUMBER=${env.BUILD_NUMBER}"
sh './gradlew clean assemble${flavor}Debug -PBUILD_NUMBER=${env.BUILD_NUMBER}'
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved

stage 'Stage Archive'
//tell Jenkins to archive the apks
archiveArtifacts artifacts: 'app/build/outputs/apk/*.apk', fingerprint: true

stage 'Stage Upload To Fabric'
sh "./gradlew crashlyticsUploadDistribution${flavor}Debug -PBUILD_NUMBER=${env.BUILD_NUMBER}"
sh './gradlew crashlyticsUploadDistribution${flavor}Debug -PBUILD_NUMBER=${env.BUILD_NUMBER}'
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved
}

// Pulls the android flavor out of the branch name the branch is prepended with /QA_
Expand Down
2 changes: 1 addition & 1 deletion jenkinsfile-examples/msbuild/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ node {

stage 'Build'
bat 'nuget restore SolutionName.sln'
bat "\"${tool 'MSBuild'}\" SolutionName.sln /p:Configuration=Release /p:Platform=\"Any CPU\" /p:ProductVersion=1.0.0.${env.BUILD_NUMBER}"
bat '\"${tool \'MSBuild\'}\" SolutionName.sln /p:Configuration=Release /p:Platform=\"Any CPU\" /p:ProductVersion=1.0.0.${env.BUILD_NUMBER}'
daniel-beck marked this conversation as resolved.
Show resolved Hide resolved

stage 'Archive'
archive 'ProjectName/bin/Release/**'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ node {
// via 'name' given for the field, 'variable:'
configFileProvider([configFile(fileId: mycfg_file, variable: 'PACKER_OPTIONS')]) {
echo " =========== ^^^^^^^^^^^^ Reading config from pipeline script "
sh "cat ${env.PACKER_OPTIONS}"
sh 'cat ${env.PACKER_OPTIONS}'
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved
echo " =========== ~~~~~~~~~~~~ ============ "

// Access to config file opens up other possibilities like
// passing on the configuration to an external script for other tasks, like,
// for example, to set generic options that can be used for generating
// binary images using packer.
echo " =========== ^^^^^^^^^^^^ Reading config via Python... "
sh "python build_image.py ${env.PACKER_OPTIONS}"
sh 'python build_image.py ${env.PACKER_OPTIONS}'
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved
echo " =========== ~~~~~~~~~~~~ ============ "
}
}
Expand Down
2 changes: 1 addition & 1 deletion pipeline-examples/slacknotify/slackNotify.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ def notifySlack(text, channel) {
channel : channel,
username : "jenkins",
icon_emoji: ":jenkins:"])
sh "curl -X POST --data-urlencode \'payload=${payload}\' ${slackURL}"
sh 'curl -X POST --data-urlencode \'payload=${payload}\' ${slackURL}'s
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ node('second-node') {

// Look, no output directory under the root!
// pwd() outputs the current directory Pipeline is running in.
sh "ls -la ${pwd()}"
sh 'ls -la ${pwd()}'
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved

// And look, output directory is there under first-stash!
sh "ls -la ${pwd()}/first-stash"
sh 'ls -la ${pwd()}/first-stash'
Kevin-CB marked this conversation as resolved.
Show resolved Hide resolved
}