Skip to content
This repository has been archived by the owner on Nov 21, 2022. It is now read-only.

Commit

Permalink
Better Docker configuration (#294)
Browse files Browse the repository at this point in the history
Changes: 

- **Added the .dockerignore:** when you in the Dockerfile do the `COPY ./APP` command it will copy all the file, also the .git folder, that are useless and so much big 

- **Added the docker-compose:** for a local usage or also to not use a docker command I had also add the docker-compose configuration

- **Fix the Dockerfile:** the application need node > 8.x but in the dockerfile is used the node 6-alpine
  • Loading branch information
thecreazy authored and jenkoian committed Oct 4, 2018
1 parent 316d46c commit db18a07
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
node_modules
CONTRIBUTING.md
LICENSE
README.MD
.git
.github
.eslintrc
.editorconfig
.env.example
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ As an alternative to the section above, you can run the app within a Docker cont

* `$ docker run -p 5000:5000 -e "GITHUB_TOKEN=YOUR_TOKEN" hacktoberfest-checker`

or use the docker-compose

* `$ docker-compose up --build`

## License

MIT © 2015-2018 [Ian Jenkins](https://github.com/jenkoian)
9 changes: 9 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
version: "3"

services:
hacktoberfest:
build: .
env_file:
- .env
ports:
- 5000:5000

0 comments on commit db18a07

Please sign in to comment.