-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct CMake issues #68
Correct CMake issues #68
Conversation
Thank you for the PR! I will review as soon as I can. |
Follow up things you should probably do:
|
…definitions - until i can figure out a solution
Bear in mind that |
Thank you again for this PR, I have integrated much of your recommendations for structure and functionality of the CMake into cpptrace on the dev branch and things seem to work well there. I will give this PR a more thorough review this weekend. Running the CI now, some test failures are expected. No worries that there are some. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good overall. I commented on some super minor things I noticed, I can take care of them after I merge.
target_compile_options( | ||
assert | ||
PRIVATE | ||
$<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wall -Wextra -Werror=return-type -Wshadow -Wundef> | ||
$<$<CXX_COMPILER_ID:GNU>:-Wuseless-cast -Wnonnull-compare> | ||
$<$<CXX_COMPILER_ID:MSVC>:/W4 /WX /permissive-> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am likely going to re-add these warnings, they're important for development
add_executable(basic tests/basic/basic_test.cpp) | ||
target_link_libraries(basic PRIVATE libassert-lib) | ||
# endif() | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newline at the end of this file would be good
3.8 .. 3.23
to just3.14