use FetchContent for magic_enum #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much, sorry again for my mistake! Do you want to handle the merge conflict or should I? |
This reverts commit 4a2baac.
|
Ok, I verified I know how to push properly to a contributor branch so I will take the liberty of merging |
|
I think the test failures are superficial. I'll merge and tweak as needed. Thanks so much for the contribution and apologies again for my clumsiness! |
|
Ok, got everything working. One thing I had to do was link magic_enum::magic_enum publicly, does that sound alright to you? |
|
Yes PUBLIC seems better as you use it on templates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.