make clear to use python2 #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Especially by now, rewriting the code snippet in Python 3 is the better option. I would be very grateful if you were to rewrite the snippet, although I can also fully understand that you've moved on in the meantime. |
|
I opened up this one: #107 on another note, @jeroenjanssens loved the first book looking forward to the next one !!! Would be happy to help triage issues on the repos if you're looking for a hand with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Jeroen,
thanks for this interesting book which I will read over Christmas! When compiling the book using bookdown, I had to explicitly state that we want to use Python2. The default on my machine is Python3, and I guess this is the case for most other users as well, and if this is not already the case, it will be in the coming years. Hence, using Python2 is just a quick-and-dirty fix, maybe the better idea is to rewrite the code snippet using Python3. Should I do that?