v2024.4.4 fix #52

jeroenterheerdt · Jun 5, 2024 · 73f060c · 73f060c
1 parent 84ef513
commit 73f060c
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 15 deletions.
diff --git a/custom_components/daily/__pycache__/__init__.cpython-312.pyc b/custom_components/daily/__pycache__/__init__.cpython-312.pyc
diff --git a/custom_components/daily/__pycache__/config_flow.cpython-312.pyc b/custom_components/daily/__pycache__/config_flow.cpython-312.pyc
diff --git a/custom_components/daily/__pycache__/const.cpython-312.pyc b/custom_components/daily/__pycache__/const.cpython-312.pyc
diff --git a/custom_components/daily/__pycache__/entity.cpython-312.pyc b/custom_components/daily/__pycache__/entity.cpython-312.pyc
diff --git a/custom_components/daily/__pycache__/exceptions.cpython-312.pyc b/custom_components/daily/__pycache__/exceptions.cpython-312.pyc
diff --git a/custom_components/daily/__pycache__/options_flow.cpython-312.pyc b/custom_components/daily/__pycache__/options_flow.cpython-312.pyc
diff --git a/custom_components/daily/__pycache__/sensor.cpython-312.pyc b/custom_components/daily/__pycache__/sensor.cpython-312.pyc
diff --git a/custom_components/daily/const.py b/custom_components/daily/const.py
@@ -3,7 +3,7 @@
 DOMAIN = "daily"
 NAME = "Daily Sensor"
 DOMAIN_DATA = f"{DOMAIN}_data"
-VERSION = "2024.4.3"
+VERSION = "2024.4.4"
 COORDINATOR = "coordinator"
 ISSUE_URL = "https://github.com/jeroenterheerdt/HADailySensor/issues"
 

diff --git a/custom_components/daily/manifest.json b/custom_components/daily/manifest.json
@@ -10,5 +10,5 @@
   "homekit": {},
   "dependencies": [],
   "codeowners": ["@jeroenterheerdt"],
-  "version": "2024.4.3"
+  "version": "2024.4.4"
 }
diff --git a/custom_components/daily/sensor.py b/custom_components/daily/sensor.py
@@ -1,9 +1,11 @@
 """Sensor platform for Daily Sensor."""
+
 import asyncio
 import logging
 from statistics import median, stdev, variance, StatisticsError
 from datetime import datetime
 
+from homeassistant.const import STATE_UNAVAILABLE, STATE_UNKNOWN
 from homeassistant.core import callback, Event
 
 # from homeassistant.helpers import entity_registry as er
@@ -96,29 +98,20 @@ def _handle_update(self, event: Event):
         input_state = self.hass.states.get(self.coordinator.input_sensor)
         state_minmax_changed = False
         try:
-            if input_state is not None:
-                if input_state.state is None:
-                    the_val = self.convert_to_float(input_state)
-                else:
-                    the_val = self.convert_to_float(input_state.state)
+            if input_state not in (None, STATE_UNKNOWN, STATE_UNAVAILABLE):
+                the_val = self.convert_to_float(input_state)
                 # apply the operation and update self._state
                 if self.coordinator.operation == CONF_SUM:
                     if self._state is None:
                         self._state = the_val
                     else:
                         self._state = self._state + the_val
                 elif self.coordinator.operation == CONF_MAX:
-                    if self._state is None:
-                        self._state = the_val
-                        state_minmax_changed = True
-                    elif the_val > self._state:
+                    if self._state is None or the_val > self._state:
                         self._state = the_val
                         state_minmax_changed = True
                 elif self.coordinator.operation == CONF_MIN:
-                    if self._state is None:
-                        self._state = the_val
-                        state_minmax_changed = True
-                    elif the_val < self._state:
+                    if self._state is None or the_val < self._state:
                         self._state = the_val
                         state_minmax_changed = True
                 elif self.coordinator.operation == CONF_MEAN:
@@ -141,6 +134,14 @@ def _handle_update(self, event: Event):
                 if state_minmax_changed:
                     self._occurrence = datetime.now()
                 self.hass.add_job(self.async_write_ha_state)
+            else:
+                # sensor is unknown at startup, state which comes after is considered as initial state
+                _LOGGER.debug(
+                    "Initial state for {} is {}".format(
+                        self.coordinator.input_sensor, input_state
+                    )
+                )
+                return
         except ValueError:
             _LOGGER.error(
                 "unable to convert to float. Please check the source sensor ({}) is available.".format(