Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mutation labelling more flexible #398

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Make mutation labelling more flexible #398

merged 2 commits into from
Nov 8, 2024

Conversation

hyanwong
Copy link
Contributor

@hyanwong hyanwong commented Nov 8, 2024

And fix a bug whereby bespoke labels led to an error

jeromekelleher
jeromekelleher approved these changes Nov 8, 2024
View reviewed changes
Copy link
Owner

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think things can be simplified using existing infrastructure. I'll merge this and you can follow up with that, if you like.

sc2ts/info.py Show resolved Hide resolved
@jeromekelleher jeromekelleher merged commit 1905fb3 into jeromekelleher:main Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromekelleher jeromekelleher jeromekelleher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyanwong @jeromekelleher