a couple small updates

jescalan · Dec 15, 2016 · 307deea · 307deea
1 parent 2db2371
commit 307deea
Show file tree

Hide file tree

Showing 5 changed files with 4,046 additions and 4 deletions.
diff --git a/.npmignore b/.npmignore
@@ -3,4 +3,4 @@ test
 .travis.yml
 Makefile
 contributing.md
-
+yarn.lock
diff --git a/lib/analytics.coffee b/lib/analytics.coffee
@@ -1,6 +1,7 @@
 Keen          = require 'keen.io'
 global_config = require './global_config'
 node          = require 'when/node'
+W             = require('when')
 
 # Yes, you can write analytics to our project. Please don't do this though.
 # Roots is an open source project. We're over here working hard to bring you
@@ -24,4 +25,4 @@ global.__track = (category, e) ->
   if enabled
     return node.call(client.addEvent.bind(client), category, e).catch(->)
   else
-    return false
+    return W.resolve(false)
diff --git a/package.json b/package.json
@@ -47,7 +47,6 @@
     "mocha-lcov-reporter": "^1.2.0",
     "mockery": "^2.0.0",
     "roots-util": "^0.2.0",
-    "selenium-webdriver": "^3.0.1",
     "sinon": "^1.17.4",
     "sinon-chai": "2.x"
   },

diff --git a/test/analytics.coffee b/test/analytics.coffee
@@ -5,7 +5,7 @@ describe 'analytics', ->
 
   it 'should be able to disable analytics through the api', ->
     Roots.analytics(disable: true)
-    __track('test', { wow: 'such test' }).should.be.false
+    __track('test', { wow: 'such test' }).should.eventually.be.false
 
   it 'should be able to enable analytics through the api', ->
     Roots.analytics(enable: true)