Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mixed simulations from mixed scenario types #29

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jessegrabowski
Copy link
Owner

@jessegrabowski jessegrabowski commented Aug 27, 2024

Previously, it was only allowed to pass one of final_values, final_value_delta, or final_pct_delta to CGEModel.scenario. One is now allowed to pass a mixture of these arguments.

Also add some simple tests of the scenario function


📚 Documentation preview 📚: https://cge-modeling--29.org.readthedocs.build/en/29/

@jessegrabowski jessegrabowski merged commit ae606df into main Aug 27, 2024
4 checks passed
@jessegrabowski jessegrabowski deleted the mixed-scenario-types branch August 27, 2024 05:48
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (3266395) to head (3272686).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   68.01%   68.68%   +0.66%     
==========================================
  Files          24       24              
  Lines        3155     3171      +16     
==========================================
+ Hits         2146     2178      +32     
+ Misses       1009      993      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant