Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of the QUIC layer. #12742

Open
wants to merge 40 commits into
base: jetty-12.1.x
Choose a base branch
from
Open

Rewrite of the QUIC layer. #12742

wants to merge 40 commits into from

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Jan 28, 2025 •
edited
Loading

Rewrite of the QUIC layer to accommodate, in the future, implementations alternative to Quiche.

@sbordet
Copy link
Contributor Author

sbordet commented Jan 28, 2025

The main work was to remove the hardcoded dependencies on Quiche.

For this reason, module jetty-quic-api is introduced with Session and Stream similar to HTTP/2 and HTTP/3.
Along with these classes, the QUIC frames defined by the spec, that appear in method signatures of Session and Stream.

The Quiche implementation is now an implementation of jetty-quic-api.

The HTTP/3 layer now only depends on jetty-quic-api.

@sbordet sbordet requested review from gregw and lorban January 28, 2025 21:37
@sbordet sbordet mentioned this pull request Jan 30, 2025
Closed
gregw
gregw requested changes Feb 4, 2025
View reviewed changes
jetty-core/jetty-quic/jetty-quic-api/src/main/java/org/eclipse/jetty/quic/api/Stream.java Outdated
* @return the {@link CompletableFuture} that gets notified when the
* frame has been sent
*/
CompletableFuture<Stream> data(boolean last, ByteBuffer... data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Callback rather than CF

...jetty-quic/jetty-quic-common/src/main/java/org/eclipse/jetty/quic/common/StreamEndPoint.java Outdated
};
}

public void write(Callback callback, List<ByteBuffer> buffers, boolean last)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think about cancelling writes

sbordet added 15 commits February 5, 2025 19:56
@sbordet
Replaced APIs that used CompletableFuture with Promise.Invocable.
f56d514 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Promise cleanup and documentation.
ad83cd1 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed StreamEndPoint.write() overrides.
a0687de 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Preserved InvocationType for BiConsumer implementations.
68bb90b 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Merged branch 'jetty-12.1.x' into 'jetty-12.1.x-quic-streams'.
eadee1d 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed test expectations.
eed4b76 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed logging that was causing NPEs.
69d7bec 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Made StreamEndPoint callback an Invocable task passed to the QUIC ses…
2bf6e34 
…sion AES.

Made Quiche.drainClearBytesForStream() return the FIN flag indication.

Improved Qpack[Decoder|Encoder] locking.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Merged branch 'jetty-12.1.x' into 'jetty-12.1.x-quic-streams'.
ec542f9 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed logic in case of BLOCKED_FRAME.
830b6a4 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Merged branch 'jetty-12.1.x' into 'jetty-12.1.x-quic-streams'.
687e239 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed logic in case of BLOCKED_FRAME for trailers.
c8907e2 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Merged branch 'jetty-12.1.x' into 'jetty-12.1.x-quic-streams'.
9477667 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Reconnected InvocationType for the server side.
10c0a8e 
Made relevant H3 unidirectional connections non-blocking.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Reduced concurrency in HttpClientLoadTest.testConcurrent().
ace30fa 
Signed-off-by: Simone Bordet <[email protected]>
lorban added a commit that referenced this pull request Feb 14, 2025
@lorban
defer H3 to after #12742
87206d9 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this pull request Feb 14, 2025
Merged
sbordet added 10 commits February 17, 2025 19:16
@sbordet
Updated documentation.
b15ab89 
Removed necessity of passing the QuicheClientQuicConfiguration to QuicheTransport, so it can now be a singleton.

Updated server module to depend on virtual http3-impl, with a default provider for http3-quiche.

Enabled ee11 client transport tests in CI.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Removed TODO.
50d249a 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Reverted removal of ClientQuicConfiguration from QuicheTransport, as …
e9877e8 
…it is necessary when QuicheTransport is used by non-HTTP/3 protocols.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed re-enabled ee11 client transport tests for H3_QUICHE.
ffa947f 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Removed the need for BooleanSupplier in MessageParser.
73dbcec 
Now relying on the returned boolean from Quiche.drainClearBytesForStream().

Updated HTTP3StreamConnection to avoid copying the HTTP/3 bytes, and use the returned boolean to generate HTTP/3 frames.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Improved test case reporting.
ab3bbb1 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed AsyncIOServletTest.
7f6996d 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Fixed release of QUIC Stream.Data.
1a3e475 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Implemented support for minInputBufferSpace in QuicheStream.
58876c1 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Improved RetainableByteBuffer reuse in QuicheStream.
ba0902a 
Signed-off-by: Simone Bordet <[email protected]>
gregw added a commit that referenced this pull request Feb 27, 2025
@gregw @lorban @sbordet
Cancel write semantic (#12727)
43e02a2 
Provide a write cancel mechanism so that removing pooled buffers can be avoided.

* Do not remove pooled buffers on write failure
* FCGI stream cancel implementation
* review H1 cancellation + make EndPoint.cancelWrite go to the failed state
* defer H3 to after #12742
* Fix H2

---------

Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Co-authored-by: Ludovic Orban <[email protected]>
Co-authored-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw requested changes

@lorban lorban Awaiting requested review from lorban

Assignees
No one assigned
Labels
build-all-tests
Projects
Jetty 12.1.0
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbordet @gregw