Update supported_features and add supported_color_modes to use new colormodes while maintaining backward compatibility. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Enum based color modes to use the correct property name and return the expected set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the supported_features function returns a ColorMode enum where HA expects binary flags. This was added here fa42052
I made this pull request after encountering the same issue as @ryanwaldron in issue #81
After reading the docs here: https://developers.home-assistant.io/docs/core/entity/light/
Implementing supported_features as binary flags and adding supported_color_modes to return the corresponding set of ColorMode enums is working for me.