Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the extension's tasks to use Node 20, or fallback to Node 10 #518

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Upgrade the extension's tasks to use Node 20, or fallback to Node 10 #518

merged 2 commits into from
Nov 6, 2024

Conversation

hanankem
Copy link
Contributor

@hanankem hanankem commented Nov 5, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used npm run format for formatting the code before submitting the pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

eyalbe4
eyalbe4 requested changes Nov 5, 2024
View reviewed changes
tasks/JFrogAudit/task.json Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 changed the title Added support for Node10 adn Node20 Added support for Node10 and Node 20 Nov 5, 2024
@eyalbe4 eyalbe4 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Nov 5, 2024
@hanankem
Copy link
Contributor Author

hanankem commented Nov 6, 2024

I have read the CLA Document and I hereby sign the CLA

@eyalbe4 eyalbe4 added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Nov 6, 2024
johnpp143
johnpp143 reviewed Nov 6, 2024
View reviewed changes
Copy link

@johnpp143 johnpp143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Node20_1" may not be required, as azure tasks globally use node 20

@eyalbe4 eyalbe4 changed the title Added support for Node10 and Node 20 Added support for Node 10 and Node 20 Nov 6, 2024
@eyalbe4 eyalbe4 changed the title Added support for Node 10 and Node 20 Upgrade the extension's tasks to use Node 20, or fallback to Node 10 Nov 6, 2024
@eyalbe4 eyalbe4 merged commit 49cb53c into jfrog:dev Nov 6, 2024
6 checks passed
@eyalbe4 eyalbe4 mentioned this pull request Nov 6, 2024
Closed
@ashokm ashokm mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpp143 johnpp143 johnpp143 left review comments

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
bug Something isn't working safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanankem @eyalbe4 @johnpp143