-
Notifications
You must be signed in to change notification settings - Fork 67
Android implementation #44
base: master
Are you sure you want to change the base?
Conversation
…awing implementation.
…some time. Looks like a caching issue?
Hey @jgrancher, any thoughts on this? I have a side project and would love to have Android support. |
@stefannew |
@leiz-me Progress on what? No one has reviewed the PR. |
@stefannew Thank you for your reply and your work. |
Oh, I see - sorry for the confusion! Yeah, I was going to think about implementing the smooth freehand stuff once I got some feedback on the PR at large - it's a big one, but like you say I guess this particular repo is inactive. I wonder if the owner would be interested in transferring it to someone else for maintenance. |
Yes, I am planning to fork this project and use your code directly for one small function on my app. Thanks! |
@stefannew @leiz-me Any chance you forked this repo and now have a secret repo waiting for us? 😄 |
I was working on a cross-platform POC with some sketch functionality and I was loving the way this performed in iOS, but was saddened to see that it was lacking an Android implementation. I checked out the closed PRs and it appears there was one in the works, but was closed in favour of another library? It didn't make much sense to me to pull in two libraries for the same problem, so I decided to take a stab at an Android implementation.
The drawing itself isn't as smooth as the iOS side of things because I haven't implemented the same smooth freehand drawing techniques detailed in the readme. I'm going to look into that this weekend, or perhaps as a follow-up PR (if this gets merged).
So far I've simply exposed the API and kept it the same as the iOS side of things:
It's definitely on the larger side due to the nature of the additions but take a look and let me know what you think.
Thanks! 🎈