Skip to content

Commit

Permalink
Merge pull request #385 from rhusar/309-upgrade-s3mock
Browse files Browse the repository at this point in the history
Investigate why the tests fail with 3.3.0 and later mock S3 container (resolve #309)
  • Loading branch information
rhusar authored Oct 25, 2024
2 parents 6d21fc1 + a154732 commit 35b1135
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ public static void setUp() {
fail("Credentials are not provided, thus Podman/Docker on Linux is required to run tests against a mock service!");
}

// TODO Since 3.3.0 the obscure cluster name tests start to fail. Manage the version manually and keep on '3.2.0' for now.
s3Mock = new S3MockContainer("3.2.0");
// Note that referring to rolling 'latest' here, a new release might break (e.g. like version 3.3.0 did) in which case,
// the version must be explicitly downgraded here.
// n.b. for reference https://hub.docker.com/r/adobe/s3mock/tags
s3Mock = new S3MockContainer("latest");
s3Mock.start();

// TODO workaround using S3MockContainer#getHttpEndpoint() by an IP address so it doesn't rely on spoofing DNS records
Expand Down

0 comments on commit 35b1135

Please sign in to comment.