Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change --with-nativecomp to --with-native-compilation #31

Closed
wants to merge 1 commit into from

Conversation

jsmestad
Copy link

This has been changed in a recent commit: https://akrl.sdf.org/gccemacs.html#orgf5ebdd1

@jimeh
Copy link
Owner

jimeh commented Feb 27, 2021

Thanks for this submission, I’m afraid I can’t merge it as is though, as it would break the ability to build from older commits listed on the known good commits issue #6. Both the old and new flags need to be supported.

Don’t worry if you can’t spare the time to address that in this PR though. I'm doing some Emacs builds this afternoon, and sorting this out is the first thing I'd be looking at :)

@jsmestad
Copy link
Author

@jimeh yeah this was a quick find-replace job so I figured there was more work to be done to make it backward-compatible. Just wanted to get it on your radar 😄

@jimeh
Copy link
Owner

jimeh commented Feb 27, 2021

A backwards compatible variant of this PR is in commit 581594d, and released as 0.4.8.

@jsmestad thanks again :)

@jimeh jimeh closed this Feb 27, 2021
@jsmestad jsmestad deleted the patch-1 branch February 28, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants