Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use new grpc version #6110

Merged
merged 54 commits into from
Dec 1, 2023
Merged

refactor: use new grpc version #6110

merged 54 commits into from
Dec 1, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Nov 17, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

dependabot bot and others added 5 commits October 25, 2023 22:03
@dependabot
chore(deps): bump google.golang.org/grpc in /jina/serve/consensus
69deb84 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.47.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.47.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@JoanFM
Merge branch 'master' into dependabot/go_modules/jina/serve/consensus…
63c9051 
…/google.golang.org/grpc-1.56.3
@jina-bot
style: fix overload and cli autocomplete
2ec8c61
@JoanFM
Merge branch 'master' into dependabot/go_modules/jina/serve/consensus…
ef01011 
…/google.golang.org/grpc-1.56.3
@JoanFM
refactor: use new grpc version
7c9a74c
@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina area/core This issue/PR affects the core codebase labels Nov 17, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2023 •
edited
Loading

Codecov Report

Attention: 200 lines in your changes are missing coverage. Please review.

Comparison is base (2a56068) 59.81% compared to head (c78f3fd) 75.24%.
Report is 1 commits behind head on master.

Files Patch % Lines
jina/orchestrate/deployments/__init__.py 5.40% 35 Missing ⚠️
...serve/consensus/add_voter/pb/add_voter_pb2_grpc.py 0.00% 35 Missing ⚠️
...erve/consensus/add_voter/pb2/add_voter_pb2_grpc.py 0.00% 35 Missing ⚠️
...ina/serve/consensus/add_voter/pb2/add_voter_pb2.py 0.00% 33 Missing ⚠️
jina/serve/consensus/add_voter/call_add_voter.py 0.00% 29 Missing ⚠️
jina/serve/consensus/add_voter/pb/add_voter_pb2.py 0.00% 21 Missing ⚠️
jina/serve/consensus/add_voter/add_voter_pb2.py 0.00% 4 Missing ⚠️
...na/serve/consensus/add_voter/add_voter_pb2_grpc.py 0.00% 4 Missing ⚠️
jina/orchestrate/flow/base.py 40.00% 3 Missing ⚠️
jina/serve/executors/run.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6110       +/-   ##
===========================================
+ Coverage   59.81%   75.24%   +15.42%     
===========================================
  Files         143      152        +9     
  Lines       13864    14069      +205     
===========================================
+ Hits         8293    10586     +2293     
+ Misses       5571     3483     -2088
Flag Coverage Δ
jina 75.24% <2.43%> (+15.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM
refactor: try no timeout grace
1448b96 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM closed this Nov 20, 2023
@JoanFM JoanFM reopened this Nov 20, 2023
@github-actions github-actions bot removed the area/core This issue/PR affects the core codebase label Nov 20, 2023
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Nov 21, 2023
@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Nov 21, 2023
@JoanFM
Merge branch 'try-new-grpc' of https://github.com/jina-ai/jina into t…
d204cd3 
…ry-new-grpc

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM
refactor: remove all warmup related code
ba4a8f2 
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM closed this Nov 30, 2023
@JoanFM JoanFM reopened this Nov 30, 2023
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Nov 30, 2023
@JoanFM JoanFM reopened this Nov 30, 2023
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Nov 30, 2023
@JoanFM JoanFM reopened this Nov 30, 2023
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot removed the area/helper This issue/PR affects the helper functionality label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM merged commit ae399ad into master Dec 1, 2023
130 of 131 checks passed
@JoanFM JoanFM deleted the try-new-grpc branch December 1, 2023 13:03
@JoanFM JoanFM mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/logging size/L size/M size/S size/XL size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanFM @jina-bot