Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make untracked local #14

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Make untracked local #14

merged 4 commits into from
Jan 1, 2024

Conversation

jinyus
Copy link
Owner

@jinyus jinyus commented Jan 1, 2024

Description

Previously, Beacon.untracked() would hide the update/access from all listeners. This PR changes its behavior so it only hides from the current effects.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9ec631d) 98.62% compared to head (0ddb295) 99.41%.
Report is 51 commits behind head on main.

Files Patch % Lines
state_beacon/lib/src/base_beacon.dart 95.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   98.62%   99.41%   +0.79%     
==========================================
  Files          26       27       +1     
  Lines         653      681      +28     
==========================================
+ Hits          644      677      +33     
+ Misses          9        4       -5     
Flag Coverage Δ
unittests 99.41% <97.18%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jinyus jinyus merged commit eed87b0 into main Jan 1, 2024
1 check passed
@jinyus jinyus deleted the patch-2 branch February 15, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants