fix: emit 'skip' for external pipeline on failure

we do not want to block the ability to merge code due to a scm-engine failure
jippi · Sep 4, 2024 · 486bae3 · 486bae3
1 parent cb49713
commit 486bae3
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/pkg/scm/gitlab/client.go b/pkg/scm/gitlab/client.go
@@ -210,13 +210,7 @@ func (client *Client) Stop(ctx context.Context, evalError error) error {
 	)
 
 	if evalError != nil {
-		status = go_gitlab.Failed
-
-		// If the evaluation failed due to no config file, consider it a "skip" instead
-		if strings.Contains(evalError.Error(), "404 Not Found") {
-			status = go_gitlab.Skipped
-		}
-
+		status = go_gitlab.Skipped
 		message = evalError.Error()
 	}