Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow CI pipeline to fail if the Change Request changes scm-engine configuration file #80

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jippi
Copy link
Owner

@jippi jippi commented Sep 10, 2024

If the Change Request does not change the scm-engine configuration file, we'll continue to fail open by succeeding the external pipeline as today.

This should prevent scm-engine configuration changes/bugs from blocking a regular Change Request not touching SCM Engine configuration files, and still provide more visual feedback to Change Requests with bad SCM-Engine configuration

…ne configuration file

otherwise, continue to fail open
@jippi jippi self-assigned this Sep 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 2.44%. Comparing base (5e4b5df) to head (45754f6).

Files with missing lines Patch % Lines
cmd/shared.go 0.00% 3 Missing ⚠️
pkg/scm/gitlab/client.go 0.00% 3 Missing ⚠️
pkg/scm/github/context.go 0.00% 2 Missing ⚠️
pkg/scm/gitlab/context.go 0.00% 2 Missing ⚠️
pkg/state/context.go 0.00% 2 Missing ⚠️
pkg/scm/github/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #80      +/-   ##
========================================
- Coverage   2.44%   2.44%   -0.01%     
========================================
  Files         48      48              
  Lines       2327    2334       +7     
========================================
  Hits          57      57              
- Misses      2262    2269       +7     
  Partials       8       8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jippi jippi merged commit dd581f2 into main Sep 10, 2024
8 checks passed
@jippi jippi deleted the better-linting-and-error-handling branch September 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants