squash: Fixes some warnings.

jitsi · Dec 1, 2023 · 3cefb36 · 3cefb36
1 parent 470217a
commit 3cefb36
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/src/main/java/org/jitsi/jigasi/TranscriptionGatewaySession.java b/src/main/java/org/jitsi/jigasi/TranscriptionGatewaySession.java
@@ -319,7 +319,7 @@ void notifyChatRoomMemberUpdated(ChatRoomMember chatMember, Presence presence)
                 }
                 catch (InterruptedException e)
                 {
-                    e.printStackTrace();
+                    logger.error(e);
                 }
 
                 if (!transcriber.isAnyParticipantRequestingTranscription())
@@ -564,7 +564,7 @@ private String getConferenceMemberResourceID(ConferenceMember member)
         }
         catch (XmppStringprepException e)
         {
-            e.printStackTrace();
+            logger.error(e);
         }
 
         return null;

diff --git a/src/main/java/org/jitsi/jigasi/transcription/WhisperConnectionPool.java b/src/main/java/org/jitsi/jigasi/transcription/WhisperConnectionPool.java
@@ -57,12 +57,9 @@ public class WhisperConnectionPool
     /**
      * Gets a connection if it exists, creates one if it doesn't.
      * @param roomId The room jid.
-     * @param participantId The participant id.
      * @return The websocket.
-     * @throws Exception When fail to initialize the socket.
      */
-    public WhisperWebsocket getConnection(String roomId, String participantId)
-        throws Exception
+    public WhisperWebsocket getConnection(String roomId)
     {
         if (!pool.containsKey(roomId))
         {
@@ -86,9 +83,7 @@ public WhisperWebsocket getConnection(String roomId, String participantId)
     public void end(String roomId, String participantId)
     {
         // execute this in new thread to not block Smack
-        threadPool.execute(() -> {
-            this.endInternal(roomId, participantId);
-        });
+        threadPool.execute(() -> this.endInternal(roomId, participantId));
     }
 
     private void endInternal(String roomId, String participantId)
@@ -99,12 +94,11 @@ private void endInternal(String roomId, String participantId)
             return;
         }
 
-        boolean isEverybodyDisconnected = false;
         try
         {
-            isEverybodyDisconnected = wsConn.disconnectParticipant(participantId);
-            if (isEverybodyDisconnected)
+            if (wsConn.disconnectParticipant(participantId))
             {
+                // remove from the pull if everyone is disconnected
                 pool.remove(roomId);
             }
         }

diff --git a/src/main/java/org/jitsi/jigasi/transcription/WhisperTranscriptionService.java b/src/main/java/org/jitsi/jigasi/transcription/WhisperTranscriptionService.java
@@ -136,14 +136,13 @@ public static class WhisperWebsocketStreamingSession
 
 
         WhisperWebsocketStreamingSession(Participant participant)
-                throws Exception
         {
             this.participant = participant;
             String[] debugName = this.participant.getDebugName().split("/");
             participantId = debugName[1];
             roomId = participant.getTranscriber().getRoomName();
             connectionPool = WhisperConnectionPool.getInstance();
-            wsClient = connectionPool.getConnection(roomId, participantId);
+            wsClient = connectionPool.getConnection(roomId);
             wsClient.setTranscriptionTag(transcriptionTag);
         }