-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle transcription api first draft #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove jdk15to18 from the banned dependencies, I guess we removed it as we do not support java 1.5 and 1.8. We may ask OCI to update that and not make it requirement so it can be excluded.
Also there are some checkstlye errors.
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/oracle/OracleRealtimeClient.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/oracle/OracleRealtimeClientListener.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/oracle/OracleServiceDisruptionException.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Show resolved
Hide resolved
src/main/java/org/jitsi/jigasi/transcription/OracleTranscriptionService.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
============================================
- Coverage 20.70% 19.66% -1.05%
- Complexity 290 293 +3
============================================
Files 76 80 +4
Lines 6313 6698 +385
Branches 838 885 +47
============================================
+ Hits 1307 1317 +10
- Misses 4787 5155 +368
- Partials 219 226 +7
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
No description provided.