Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle transcription api first draft #541

Merged
merged 12 commits into from
Aug 13, 2024

Conversation

rpurdel
Copy link
Contributor

@rpurdel rpurdel commented Aug 9, 2024

No description provided.

@rpurdel rpurdel requested review from bgrozev and damencho August 9, 2024 06:24
Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove jdk15to18 from the banned dependencies, I guess we removed it as we do not support java 1.5 and 1.8. We may ask OCI to update that and not make it requirement so it can be excluded.

Also there are some checkstlye errors.

@rpurdel rpurdel requested review from bgrozev and damencho August 12, 2024 12:55
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 241 lines in your changes missing coverage. Please review.

Project coverage is 19.66%. Comparing base (6e60482) to head (5e6c0a4).
Report is 10 commits behind head on master.

Files Patch % Lines
...asi/transcription/oracle/OracleRealtimeClient.java 0.00% 128 Missing ⚠️
...gasi/transcription/OracleTranscriptionService.java 0.00% 106 Missing ⚠️
...ption/oracle/OracleServiceDisruptionException.java 0.00% 4 Missing ⚠️
...gasi/transcription/PCMAudioSilenceMediaDevice.java 0.00% 2 Missing ⚠️
...asi/transcription/WhisperTranscriptionService.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
- Coverage     20.70%   19.66%   -1.05%     
- Complexity      290      293       +3     
============================================
  Files            76       80       +4     
  Lines          6313     6698     +385     
  Branches        838      885      +47     
============================================
+ Hits           1307     1317      +10     
- Misses         4787     5155     +368     
- Partials        219      226       +7     
Files Coverage Δ
...si/transcription/PCMAudioSilenceCaptureDevice.java 0.00% <ø> (ø)
...asi/transcription/WhisperTranscriptionService.java 0.00% <0.00%> (ø)
...gasi/transcription/PCMAudioSilenceMediaDevice.java 0.00% <0.00%> (ø)
...ption/oracle/OracleServiceDisruptionException.java 0.00% <0.00%> (ø)
...gasi/transcription/OracleTranscriptionService.java 0.00% <0.00%> (ø)
...asi/transcription/oracle/OracleRealtimeClient.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a3211b...5e6c0a4. Read the comment docs.

@damencho damencho merged commit 9953c9a into jitsi:master Aug 13, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants