Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an option to disable discarding silence. #2289

Merged
merged 1 commit into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class AudioLevelReader(
val silence = level == MUTED_LEVEL

if (!silence) stats.nonSilence(AudioLevelHeaderExtension.getVad(ext))
if (silence && forwardedSilencePackets > forwardedSilencePacketsLimit) {
if (silence && discardSilence && forwardedSilencePackets > forwardedSilencePacketsLimit) {
packetInfo.shouldDiscard = true
stats.discardedSilence()
} else if ([email protected]) {
Expand Down Expand Up @@ -111,6 +111,9 @@ class AudioLevelReader(
private val forwardedSilencePacketsLimit: Int by config {
"jmt.audio.level.forwarded-silence-packets-limit".from(JitsiConfig.newConfig)
}
private val discardSilence: Boolean by config {
"jmt.audio.level.discard-silence".from(JitsiConfig.newConfig)
}
}
}

Expand Down
3 changes: 3 additions & 0 deletions jitsi-media-transform/src/main/resources/reference.conf
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ jmt {
// Number of RTP packets with 0 audio level to forward before start discarding (to avoid CNG noise in muted state
// if DTX is enabled).
forwarded-silence-packets-limit = 3

// Whether to discard packets marked with silence (audio level 0) in the receive pipeline.
discard-silence = true
}
}

Expand Down