Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate browser/BrowserCapabilities #2658

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

naman9271
Copy link
Contributor

Overview

This PR migrates the BrowserCapabilities module from JavaScript to TypeScript. The migration includes type definitions, interface extensions, and the addition of new methods to enhance browser capability detection.

Major Changes

1. New Methods Added

  • getOSVersion():
  • _getIOSVersion():
  • isIosBrowser():
  • etc.

2. TypeScript Error Resolutions

  • getting the type errors as they are not exist in their parent so I add them as any if it is not okay please guide what to assign their types
  • (window.RTCRtpSender.prototype as any).createEncodedStreams))
  • return typeof (navigator as any).getDisplayMedia === 'function'

Fixes #2637

@naman9271 naman9271 changed the title Migrate browser capabilities Migrate browser/BrowserCapabilities Feb 24, 2025
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@naman9271
Copy link
Contributor Author

@saghul please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating Files To Typescript
2 participants