Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate red/red #2664

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Migrate red/red #2664

wants to merge 6 commits into from

Conversation

naman9271
Copy link
Contributor

Fixes #2637

Major Change

  1. Added Metadata Support:

    • Implemented the getMetadata method in the newFrame object to comply with the RTCEncodedAudioFrame interface. This method returns an object containing contributingSources and synchronizationSource.
    const newFrame: RTCEncodedAudioFrame = {
        data: data.buffer, // Use the underlying ArrayBuffer
        timestamp: encodedFrame.timestamp,
        getMetadata: () => {
            return {
                contributingSources: [], // Provide appropriate values as needed
                synchronizationSource: undefined, // Provide appropriate values as needed
            };
        },
    };
  2. Redundancy Handling Logic:

    • Enhanced the addRedundancy method to correctly handle the addition of redundancy to the audio frames. This includes calculating the necessary lengths and constructing the frame headers according to RFC 2198 specifications.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@naman9271
Copy link
Contributor Author

@saghul Please Review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating Files To Typescript
2 participants