Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logs #7

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Add support for logs #7

merged 1 commit into from
Jun 28, 2024

Conversation

jjatria
Copy link
Owner

@jjatria jjatria commented Nov 21, 2023

Note that this branch will be rebased on a periodic basis to stay on top of changes in main. If you are checking this out early, do remember to do git pull -r to avoid conflicts.

@coveralls
Copy link

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 9718680541

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.6%) to 88.372%

Totals Coverage Status
Change from base Build 8931045854: 5.6%
Covered Lines: 38
Relevant Lines: 43

💛 - Coveralls

@jjatria jjatria force-pushed the logs branch 4 times, most recently from e50dc71 to b9fb526 Compare May 3, 2024 17:29
@jjatria jjatria marked this pull request as ready for review May 3, 2024 17:29
@jjatria jjatria changed the title WIP: Add support for logs Add support for logs May 3, 2024
@jjatria
Copy link
Owner Author

jjatria commented May 3, 2024

This branch is ready to be merged

@jjatria
Copy link
Owner Author

jjatria commented May 3, 2024

@tm604 Do you think you might be able to give this PR a look?

I've been using this on a test environment, and I'm now happy with the way it looks. I think this can be merged and released to CPAN safely, since nothing will be using it.

After this is out, we can think about the order in which the API (jjatria/perl-opentelemetry#7) and the SDK (jjatria/perl-opentelemetry-sdk#6) PRs for logs support can be merged and released, perhaps increasing the required versions.

@tm604
Copy link

tm604 commented May 6, 2024

This sounds great, thanks - I'll try out the branch to see if any new or exciting issues appear, but on first glance it's looking good 👍

@jjatria jjatria merged commit a2c05ea into main Jun 28, 2024
5 checks passed
@jjatria jjatria deleted the logs branch June 28, 2024 21:41
@jjatria
Copy link
Owner Author

jjatria commented Jun 28, 2024

This was released to CPAN as 0.016001-TRIAL, but I expect it to be bumped to 0.017 in the next coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants