Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty returned dictionary from request-function #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle empty returned dictionary from request-function #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions homekit/controller/ble_impl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def get_characteristics(self, characteristics, include_meta=False, include_perms
self.session = None
raise e

if response.first_by_id(AdditionalParameterTypes.Value):
if response and response.first_by_id(AdditionalParameterTypes.Value):
value = self._convert_to_python(aid, cid, response.first_by_id(AdditionalParameterTypes.Value).data)
else:
value = None
Expand Down Expand Up @@ -557,7 +557,8 @@ def request(self, feature_char, feature_char_id, op, body=None):
logger.debug('decrypted: %s', bytearray(data).hex())

if not data:
return {}
logger.debug('decryption failed')
return tlv8.EntryList()

# parse header and check stuff
logger.debug('parse sig read response %s', bytes([int(a) for a in data]).hex())
Expand Down