Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing OMPT callbacks #6

Open
wants to merge 2 commits into
base: openmp5-gpu
Choose a base branch
from

Conversation

FuriousBerserker
Copy link

A patch from Lechen Yu

@jmellorcrummey
Copy link
Owner

Thanks for the pull request.

Please update the pull request to remove the default arguments to the declarations and calls to the following routines.

void target_enter_data(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);
void target_exit_data(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);
void target_update(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);
void target(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);

…ata, target_exit_data, target_update, target. Add an ompt routine, target_data_associate, for data mappings in declare target directive
@FuriousBerserker
Copy link
Author

Thanks for the pull request.

Please update the pull request to remove the default arguments to the declarations and calls to the following routines.

void target_enter_data(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);
void target_exit_data(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);
void target_update(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);
void target(int64_t device_id, ompt_scope_endpoint_t scope = ompt_scope_begin);

Hi, John,

I have removed those default arguments. In addition, I add a new ompt routine for data mappings in declare target construct. If there is any other problem in the pull request, please let me know. I may submit more commits if I find other missing ompt routines.

Best,
Lechen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants