Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: OMPT corner cases (unsafe way to free parallel region's team) #8

Open
wants to merge 1 commit into
base: ompt-final-barrier
Choose a base branch
from

Conversation

vladaindjic
Copy link

Temporary solution for two bugs:

  1. parallel_data at level 0 present, but not at outer levels (1, 2, etc.), even though there are few levels of nested regions. Reason: The descriptor of the innermost parallel region invalidates the pointer to parent region too early.
  2. The same region descriptor may be passed multiple times to ompt_callback_parallel_end. Reason: Using (sending to the ompt_callback_parallel_end) pointer to the field of region's descriptor which was previously put in the free list.

Examples that described temporary resolved bugs can be found in the comments in source code.

1. parallel_data at level 0 present, but not at outer levels (1, 2, etc.), even though there are few levels of nested regions.
2. The same region descriptor may be passed multiple times to ompt_callback_parallel_end.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant